93212[FEATURE] Support HTML5 download attribute in file link browser
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Guido Schmechel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/TypeScript/backend/element/link-browser-download-element.tsnew+86 −0
- Build/Sources/TypeScript/backend/link-browser.ts+1 −0
- Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts+23 −2
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php3+10 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_browse_links.xlf+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/link-browser-download-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/link-browser.js+1 −1
- typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php+10 −3
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-100254-SupportDownloadAttributeInFileLinkBrowser.rstnew+42 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/TypoLinkCodecServiceTest.php+71 −0
- typo3/sysext/filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+6 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js+1 −1
Review log 1011
-
Benni Mack uploaded patch set 1 03/16/26, 20:18
-
core-ci voted on patch set 1 V +1 03/16/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98050
-
Benni Mack marked it ready for review 03/16/26, 20:49
-
Garvin Hicking commented on patch set 1 03/16/26, 21:26
-
Simon Schaufelberger commented on patch set 1 03/16/26, 22:12
AbstractLinkBrowserController.php:519Replyor use my new rector rule which can handle that as well ;) -
Benni Mack commented on patch set 1 03/16/26, 22:47
AbstractLinkBrowserController.php:519Replyno skills used in this case.. :) I am actually waiting for this one, which I need to finish as well: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92336 I consider sL() should be removed very very soon, I still to sL() long syntax in PHP so it is easier for me to grep later-on. then switching to ->translate() separately. -
Guido Schmechel commented on patch set 1 03/28/26, 18:42
The feature works in principle. However, I’m not entirely happy with the layout of the fields. And wouldn’t a description be useful for ‘Custom filename’ as well? -
Garvin Hicking commented on patch set 1 CR +1 V +1 03/30/26, 18:15
(Personally I think the field layout is "not great but ok"; we could iterate on this? IMO a description field for custom filename would bloat it up considerably and it does feel self-explanatory...) -
Guido Schmechel commented on patch set 1 CR +1 V +1 03/30/26, 18:25
No need for me to create a block for this patch. If the fields are sorted out in a follow-up, I’m happy :-D I’ll leave it to the experts to decide whether the description makes sense. The other fields aren’t described either, after all. -
Garvin Hicking voted on patch set 1 CR +2 V +2 03/30/26, 19:06
-
Garvin Hicking merged patch set 2 03/30/26, 19:06
AbstractLinkBrowserController.php:519