Review main Merged

93212[FEATURE] Support HTML5 download attribute in file link browser

Benni Mack CR +2 V +2 Hard +271 −9 updated 03/30/26, 19:06

Commit message

The file link browser now offers a "Force download" checkbox
that sets the HTML5 download attribute on anchor tags. When
enabled, an optional "Custom filename" field allows editors to
specify an alternative filename for the downloaded file.

The TypoLink codec is extended with an optional seventh
segment for the download value. "true" produces a boolean
download attribute (<a download>), any other string produces
a named variant (<a download="custom-name.pdf">).

CKEditor integration stores and restores the attribute via
the linkDownload model attribute, so the download flag
round-trips through the RTE without loss.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1011

  1. Benni Mack uploaded patch set 1 03/16/26, 20:18

  2. core-ci voted on patch set 1 V +1 03/16/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98050

  3. Benni Mack marked it ready for review 03/16/26, 20:49

  4. Garvin Hicking commented on patch set 1 03/16/26, 21:26

    AbstractLinkBrowserController.php:519

    AI needs to know about new domain language syntax, update the skill 😎
  5. Simon Schaufelberger commented on patch set 1 03/16/26, 22:12

    AbstractLinkBrowserController.php:519 Reply

    or use my new rector rule which can handle that as well ;)
  6. Benni Mack commented on patch set 1 03/16/26, 22:47

    AbstractLinkBrowserController.php:519 Reply

    no skills used in this case.. :) I am actually waiting for this one, which I need to finish as well: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92336 I consider sL() should be removed very very soon, I still to sL() long syntax in PHP so it is easier for me to grep later-on. then switching to ->translate() separately.
  7. Guido Schmechel commented on patch set 1 03/28/26, 18:42

    The feature works in principle. However, I’m not entirely happy with the layout of the fields. And wouldn’t a description be useful for ‘Custom filename’ as well?
  8. Garvin Hicking commented on patch set 1 CR +1 V +1 03/30/26, 18:15

    (Personally I think the field layout is "not great but ok"; we could iterate on this? IMO a description field for custom filename would bloat it up considerably and it does feel self-explanatory...)
  9. Guido Schmechel commented on patch set 1 CR +1 V +1 03/30/26, 18:25

    No need for me to create a block for this patch. If the fields are sorted out in a follow-up, I’m happy :-D I’ll leave it to the experts to decide whether the description makes sense. The other fields aren’t described either, after all.
  10. Garvin Hicking voted on patch set 1 CR +2 V +2 03/30/26, 19:06

  11. Garvin Hicking merged patch set 2 03/30/26, 19:06