Review main Merged

93232[TASK] Update bacon/bacon-qr-code to 3.0.4

Garvin Hicking CR +2 V +2 Easy +14 −13 updated 03/17/26, 10:28

Commit message

Changes in the QR-Code generator suggest an update
to the library, so that proper SVG sizes are generated.

The background color now uses #ffffff instead of #fefefe.

Executed command:

> Build/Scripts/runTests.sh -s composer -- \
    require --no-update -d typo3/sysext/core \
      bacon/bacon-qr-code:^3.0.4 \
  && Build/Scripts/runTests.sh -s composer -- \
    require bacon/bacon-qr-code:^3.0.4

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Garvin Hicking uploaded patch set 1 03/17/26, 06:24

  2. core-ci voted on patch set 1 V -1 03/17/26, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98070

  3. Stefan Bürk uploaded patch set 2 V -1 03/17/26, 08:39

  4. core-ci voted on patch set 2 V +1 03/17/26, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98076

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/17/26, 09:01

  6. Oliver Klee voted on patch set 2 CR +1 V +1 03/17/26, 09:17

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 03/17/26, 10:13

  8. Stefan Bürk merged patch set 3 03/17/26, 10:13

  9. Oliver Hader voted on patch set 3 CR +1 03/17/26, 10:28