Review main Merged

93233[BUGFIX] Avoid stripping input field preview values

Matthias Vogel CR +2 V +2 Easy +42 −7 updated 04/13/26, 11:35

Commit message

Only text fields should be processed with strip_tags() in the
content element preview.

Input fields may contain plain text with characters like "<".
Those values must stay visible in the preview and be rendered
escaped instead of being stripped completely.

And a drive-by fix for Camino ContentPreviews having the wrong template.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Matthias Vogel uploaded patch set 1 03/17/26, 06:24

  2. Matthias Vogel marked it ready for review 03/17/26, 06:25

  3. core-ci voted on patch set 1 V +1 03/17/26, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98071

  4. Benni Mack commented on patch set 1 03/17/26, 13:17

    RecordFieldPreviewProcessor.php:103

    I think we use "isType()" usually
  5. Matthias Vogel uploaded patch set 2 V +1 03/18/26, 09:31

  6. core-ci voted on patch set 2 V +1 03/18/26, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98157

  7. Matthias Vogel commented on patch set 2 03/18/26, 09:53

    RecordFieldPreviewProcessor.php:103 Reply

    Done
  8. Matthias Vogel commented on patch set 2 04/13/26, 10:14

    RecordFieldPreviewProcessorTest.php:119

    make fieldName not optional

    page.tsconfig:136

    add comment into commit message about this change.
  9. Matthias Vogel uploaded patch set 3 V +1 04/13/26, 10:41

  10. Matthias Vogel commented on patch set 3 04/13/26, 10:41

    RecordFieldPreviewProcessorTest.php:119 Reply

    Done

    page.tsconfig:136 Reply

    Done
  11. core-ci voted on patch set 3 V -1 04/13/26, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100069

  12. core-ci commented on patch set 3 04/13/26, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100069

  13. core-ci voted on patch set 3 V +1 04/13/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100069

  14. Christian Kuhn voted on patch set 3 CR +1 V +1 04/13/26, 11:32

  15. Stefan Bürk voted on patch set 3 CR +2 V +2 04/13/26, 11:35

  16. Stefan Bürk merged patch set 4 04/13/26, 11:35