Review main Merged

93237[TASK] Do not wrap content in tab-content in NoTabsContainer

Benjamin Kott CR +2 V +2 Easy +5 −6 updated 03/18/26, 07:18

Commit message

The NoTabsContainer previously wrapped its rendered content in an
unnecessary `<div class="tab-content">` wrapper. Since this container
explicitly handles the no-tabs case, this wrapper served no purpose and
caused form sections inside panels to display with top border radii due
to missing CSS resets.

Remove the superfluous wrapper and add border-start-end-radius and
border-start-start-radius resets for form sections nested within panels
to ensure a consistent appearance.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benjamin Kott uploaded patch set 1 03/17/26, 22:11

  2. core-ci voted on patch set 1 V +1 03/17/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98112

  3. Benjamin Franzke commented on patch set 1 CR +1 V +1 03/18/26, 04:05

    _panel.scss:525

    can be seen in `"styleguide TCA demo" > flex > section container > secton > container_1` (which contains rounded instead of rectangular borders.

    NoTabsContainer.php:36

    Can be seen in `"styleguide TCA demo" > type`
  4. Josua Vogel voted on patch set 1 CR +1 V +1 03/18/26, 06:29

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 03/18/26, 07:18

  6. Benjamin Kott merged patch set 2 03/18/26, 07:18