93238[TASK] Remove position-try-order from dropdown menu
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 68
-
Benjamin Kott uploaded patch set 1 03/17/26, 23:10
-
core-ci voted on patch set 1 V -1 03/17/26, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98113
-
core-ci voted on patch set 1 V +1 03/17/26, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98113
-
Benjamin Franzke commented on patch set 1 03/18/26, 03:50
I can not follow this argumentation. Please see https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/position-try-order#description for reference: > The position-try-order property has a slightly different focus from the rest of the position-try functionality features, in that it makes use of position-try fallback options when the positioned element is first displayed, rather than when it is being scrolled Per this definition scrolling should not be affected by this property at all. Let's talk about this later.We should you name (here or in the issue) a concrete dropdown that is affected. -
Benjamin Kott commented on patch set 1 03/18/26, 07:14
Reply
what should and what should not ... browsersReply
configuration -> globals (expand and scroll to bottom) -> share -
Georg Ringer voted on patch set 1 CR +1 V +1 03/18/26, 07:51
-
Benjamin Franzke commented on patch set 1 CR +2 V +2 03/18/26, 08:01
Reply
Ok, that means it is incorrectly positioned when "already" scrolled down and when the dropdown is opened afterwards. Therefore browsers actually behave correctly here, since only the initial position as affected, as documented. We're good to merg ehere.Reply
Acknowledged -
Benjamin Franzke merged patch set 2 03/18/26, 08:01