Review main Merged

93239[BUGFIX] Use strict empty check for HTTP header values

Oliver Hader CR +2 V +2 Easy +1 −1 updated 03/18/26, 06:25

Commit message

!empty($value) incorrectly skips HTTP headers whose value is
a falsy non-empty string such as "0". This has been replaced
with a strict string comparison $value !== '' to ensure such
headers are included when building the server request.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Markus Klein +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Markus Klein +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oliver Hader uploaded patch set 1 03/17/26, 23:14

  2. core-ci voted on patch set 1 V +1 03/17/26, 23:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98114

  3. Markus Klein voted on patch set 1 CR +1 V +1 03/17/26, 23:35

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 03/17/26, 23:55

  5. Josef Glatz voted on patch set 1 CR +1 V +1 03/18/26, 04:45

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/18/26, 05:16

  7. Benjamin Franzke merged patch set 2 03/18/26, 06:25