Review main Merged

93244[BUGFIX] Do not refresh page tree on each context panel save

Oli Bartsch CR +2 V +2 Easy +0 −7 updated 03/18/26, 09:45

Commit message

The ContextualRecordEditController dispatched updatePageTree
on every successful save via BackendUtility::setUpdateSignal().
This caused the page tree to visually flash in the background
on each save, which is distracting and inconsistent since the
content frame is not refreshed at that point either.

The page tree refresh is already handled by the JavaScript-side
trigger (contextual-record-edit-trigger) when the context panel
is actually closed, making the PHP-side signal redundant.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 58

  1. Oli Bartsch uploaded patch set 1 03/18/26, 08:40

  2. Benjamin Franzke commented on patch set 1 CR +1 V +1 03/18/26, 08:45

    good point, maybe we can discuss to avoid flashing the page tree while reloading data. (if there is already data, we should the loading indicator at another place, instead of immediately "hiding" all current pages) For now I agree to remove the update, basically because the page content is not updated as well. I think it would be fine to reintroduce this later on when we * manage to update the page tree less intrusive * update page tree and page contents.
  3. Benjamin Kott voted on patch set 1 CR +1 V +1 03/18/26, 08:46

  4. core-ci voted on patch set 1 V -1 03/18/26, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98147

  5. core-ci commented on patch set 1 03/18/26, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98147

  6. core-ci voted on patch set 1 V +1 03/18/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98147

  7. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/18/26, 09:45

  8. Benjamin Franzke merged patch set 2 03/18/26, 09:45