Review main Merged

93245[TASK] Render field descriptions next to the label in FormEngine

Benjamin Kott CR +2 V +2 Hard +231 −479 updated 05/24/26, 08:24

Commit message

Field descriptions are not type-specific behavior but a general
property of any TCA field, just like the label itself. Rendering them
through a per-element fieldInformation node required every element to
register TcaDescription individually, even though the result was
always the same: a description shown somewhere in the element body.

Descriptions are now rendered by AbstractFormElement::renderDescription()
and AbstractContainer::renderDescription() as part of the label
rendering, directly after the label or legend element. This matches
how the label is handled: once, at the framework level, independent
of the specific element type.

The TcaDescription field information render type is deprecated and
all default fieldInformation registrations have been removed from
core elements and containers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 47

Show 27 more files

Review log 1319

  1. Benjamin Kott uploaded patch set 1 03/18/26, 11:51

  2. Benjamin Kott uploaded patch set 2 03/18/26, 11:55

  3. core-ci voted on patch set 1 V -1 03/18/26, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98169

  4. core-ci voted on patch set 2 V -1 03/18/26, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98170

  5. Benjamin Kott uploaded patch set 3 V -1 03/18/26, 12:43

  6. Benjamin Kott uploaded patch set 4 03/18/26, 12:44

  7. core-ci voted on patch set 3 V -1 03/18/26, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98184

  8. Benjamin Kott uploaded patch set 5 03/18/26, 13:05

  9. core-ci voted on patch set 5 V +1 03/18/26, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98187

  10. core-ci voted on patch set 4 V -1 03/18/26, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98185

  11. Simon Schaufelberger commented on patch set 5 03/18/26, 14:36

    AbstractContainer.php:157

    can you extract that into a getter of the LanguageService?

    Deprecation-109280-FormEngineTcaDescriptionFieldInformation.rst:5

    not the same length as the title
  12. Benjamin Franzke uploaded patch set 6 V +1 03/18/26, 15:21

  13. Benjamin Franzke commented on patch set 6 03/18/26, 15:21

    AbstractContainer.php:157 Reply

    Done

    Deprecation-109280-FormEngineTcaDescriptionFieldInformation.rst:5 Reply

    Done
  14. core-ci voted on patch set 6 V +1 03/18/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98205

  15. Simon Schaufelberger voted on patch set 6 CR +1 V +1 03/18/26, 15:32

  16. Garvin Hicking voted on patch set 6 CR +1 V +1 03/18/26, 15:45

  17. Georg Ringer voted on patch set 6 CR +2 V +2 03/18/26, 17:36

  18. Georg Ringer merged patch set 7 03/18/26, 17:36

  19. Lina Wolf commented on patch set 7 05/24/26, 08:24