93246[BUGFIX] Use Popover API for notifications
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Richard Krikler +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Richard Krikler +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 3
Files 6
- Build/Sources/Sass/element/typo3-notification-message.scss+3 −9
- Build/Sources/TypeScript/backend/modal.ts+28 −0
- Build/Sources/TypeScript/backend/notification.ts3+18 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −7
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+1 −1
Review log 2640
Show 1115 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/18/26, 12:03
-
Benjamin Franzke uploaded patch set 2 03/18/26, 12:04
-
core-ci voted on patch set 2 V -1 03/18/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98174
-
Benjamin Franzke uploaded patch set 3
V -103/18/26, 14:40 -
core-ci voted on patch set 3 V -1 03/18/26, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98199
-
core-ci voted on patch set 3 V +1 03/18/26, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98199
-
Andreas Kienast voted on patch set 3 CR +1 V +1 03/19/26, 09:10
-
Josua Vogel voted on patch set 3 CR +1 V +1 03/20/26, 14:17
-
Richard Krikler commented on patch set 3 03/22/26, 08:29
Nice. The notifications are now visible on top of opened modals. But: I cannot interact (neither mouse or keyboard) with the close (or "Clear all") button on an opened modal. Tested with "Extension Configuration" on-save. My "naive" approach would be to move (on-open) the entire #alert-container into the currently open dialog. Then the notification would be interactive. This is also related to #108360. -
Richard Krikler commented on patch set 3 03/22/26, 09:45
notification.ts:133Why is `showPopover()` called here directly, when it has already been called in `containerItemVisibility()`? Would it be fine to move `containerItemVisibility()` where `showPopover()` is currently called? ```suggestion this.messageContainer.prepend(this.clearAllButton); document.body.appendChild(this.messageContainer); this.containerItemVisibility(); ``` -
Benjamin Franzke commented on patch set 3 CR -1 03/23/26, 08:12
Reply
ugh, sounds bad. will check, thx! -
Benjamin Franzke commented on patch set 3 04/15/26, 15:37
Reply
I initially thought this is a browser bug, but it is actually by design (bad for us): > https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog > A Document document is blocked by a modal dialog subject if subject is the topmost dialog element in document's top layer. While document is so blocked, every *node that is connected to document*, with the exception of the subject element and its flat tree descendants, must become *inert*. Also see https://github.com/whatwg/html/issues/9936 In other words: I currently do not have a solution. 😞 -
Benjamin Franzke uploaded patch set 4
CR +1V +104/15/26, 17:22 -
core-ci voted on patch set 4 V -1 04/15/26, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100268
-
Benjamin Franzke uploaded patch set 5
V -104/15/26, 17:51
-
core-ci voted on patch set 5 V -1 04/15/26, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100269
-
Benjamin Franzke uploaded patch set 6
V -104/16/26, 03:43 -
core-ci voted on patch set 6 V -1 04/16/26, 03:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100280
-
Benjamin Franzke uploaded patch set 7
V -104/16/26, 04:01 -
core-ci voted on patch set 7 V -1 04/16/26, 04:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100281
-
Benjamin Franzke uploaded patch set 8
V -104/16/26, 04:15 -
core-ci voted on patch set 8 V -1 04/16/26, 04:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100286
-
Benjamin Franzke uploaded patch set 9
V -104/16/26, 08:51 -
core-ci voted on patch set 9 V -1 04/16/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100304
-
Benjamin Franzke uploaded patch set 10
V -104/16/26, 11:27 -
core-ci voted on patch set 10 V +1 04/16/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100309
-
Benjamin Franzke updated the commit message in patch set 11
V +104/16/26, 12:06 -
Benjamin Franzke commented on patch set 11 04/16/26, 12:09
Reply
Thanks again for reporting, this was important. I've applied the only known workaround, as described in https://github.com/whatwg/html/issues/9936#issuecomment-2905180369 Please recheck 😊notification.ts:133ReplyBecause it is not attached to the document while called in `containerItemVisibility()` -
core-ci voted on patch set 11 V +1 04/16/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100315
-
Richard Krikler commented on patch set 11 V +1 04/16/26, 12:16
Reply
Thank you for the fix/ workaround ❤️notification.ts:133ReplyAcknowledged -
Benjamin Franzke uploaded patch set 12
V +107/22/26, 06:40Rebase -
Benjamin Franzke updated the commit message in patch set 13 07/22/26, 06:42
-
core-ci voted on patch set 13 V -1 07/22/26, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105149
-
core-ci voted on patch set 12 V -1 07/22/26, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105146
-
Benjamin Franzke uploaded patch set 14
V -109/15/26, 07:15 -
core-ci voted on patch set 14 V +1 09/15/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108584
-
Richard Krikler voted on patch set 14 CR +1 V +1 09/15/26, 07:41
-
Benjamin Kott voted on patch set 14 CR +1 V +1 09/15/26, 07:47
-
Benjamin Franzke voted on patch set 14 CR +2 V +2 09/15/26, 07:48
-
Benjamin Franzke merged patch set 15 09/15/26, 08:23