Review main Merged

93246[BUGFIX] Use Popover API for notifications

Benjamin Franzke CR +2 V +2 Normal +56 −20 updated 09/15/26, 08:23

Commit message

Using Popover API provides builtin accessibility
features and avoids manual z-index coordination.
and allows to show above modals (with a small constraint [1]).

This will allow to avoid having to add custom
success notifications in modal windows, as required
for #109130 and ensure notifications from slug updates
are visible when using the contextual editing panel.

[1] In order to make popovers interactive, when a `<dialog>` is
    opened – see https://github.com/whatwg/html/issues/9936 – the
    alert container is mounted into the topmost `<dialog>` element.
    This is the only known workaround to a limitation of the `<dialog>`
    specification which makes all elements outside the topmost
    `<dialog>` inert. Also see:
    https://github.com/whatwg/html/issues/9936#issuecomment-2905180369

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Richard Krikler +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Richard Krikler +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 2640

Show 1115 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/18/26, 12:03

  2. Benjamin Franzke uploaded patch set 2 03/18/26, 12:04

  3. core-ci voted on patch set 2 V -1 03/18/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98174

  4. Benjamin Franzke uploaded patch set 3 V -1 03/18/26, 14:40

  5. core-ci voted on patch set 3 V -1 03/18/26, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98199

  6. core-ci voted on patch set 3 V +1 03/18/26, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98199

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 03/19/26, 09:10

  8. Josua Vogel voted on patch set 3 CR +1 V +1 03/20/26, 14:17

  9. Richard Krikler commented on patch set 3 03/22/26, 08:29

    Nice. The notifications are now visible on top of opened modals. But: I cannot interact (neither mouse or keyboard) with the close (or "Clear all") button on an opened modal. Tested with "Extension Configuration" on-save. My "naive" approach would be to move (on-open) the entire #alert-container into the currently open dialog. Then the notification would be interactive. This is also related to #108360.
  10. Richard Krikler commented on patch set 3 03/22/26, 09:45

    notification.ts:133

    Why is `showPopover()` called here directly, when it has already been called in `containerItemVisibility()`? Would it be fine to move `containerItemVisibility()` where `showPopover()` is currently called? ```suggestion this.messageContainer.prepend(this.clearAllButton); document.body.appendChild(this.messageContainer); this.containerItemVisibility(); ```
  11. Benjamin Franzke commented on patch set 3 CR -1 03/23/26, 08:12

    Reply

    ugh, sounds bad. will check, thx!
  12. Benjamin Franzke commented on patch set 3 04/15/26, 15:37

    Reply

    I initially thought this is a browser bug, but it is actually by design (bad for us): > https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog > A Document document is blocked by a modal dialog subject if subject is the topmost dialog element in document's top layer. While document is so blocked, every *node that is connected to document*, with the exception of the subject element and its flat tree descendants, must become *inert*. Also see https://github.com/whatwg/html/issues/9936 In other words: I currently do not have a solution. 😞
  13. Benjamin Franzke uploaded patch set 4 CR +1 V +1 04/15/26, 17:22

  14. core-ci voted on patch set 4 V -1 04/15/26, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100268

  15. Benjamin Franzke uploaded patch set 5 V -1 04/15/26, 17:51

  1. core-ci voted on patch set 5 V -1 04/15/26, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100269

  2. Benjamin Franzke uploaded patch set 6 V -1 04/16/26, 03:43

  3. core-ci voted on patch set 6 V -1 04/16/26, 03:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100280

  4. Benjamin Franzke uploaded patch set 7 V -1 04/16/26, 04:01

  5. core-ci voted on patch set 7 V -1 04/16/26, 04:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100281

  6. Benjamin Franzke uploaded patch set 8 V -1 04/16/26, 04:15

  7. core-ci voted on patch set 8 V -1 04/16/26, 04:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100286

  8. Benjamin Franzke uploaded patch set 9 V -1 04/16/26, 08:51

  9. core-ci voted on patch set 9 V -1 04/16/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100304

  10. Benjamin Franzke uploaded patch set 10 V -1 04/16/26, 11:27

  11. core-ci voted on patch set 10 V +1 04/16/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100309

  12. Benjamin Franzke updated the commit message in patch set 11 V +1 04/16/26, 12:06

  13. Benjamin Franzke commented on patch set 11 04/16/26, 12:09

    Reply

    Thanks again for reporting, this was important. I've applied the only known workaround, as described in https://github.com/whatwg/html/issues/9936#issuecomment-2905180369 Please recheck 😊

    notification.ts:133 Reply

    Because it is not attached to the document while called in `containerItemVisibility()`
  14. core-ci voted on patch set 11 V +1 04/16/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100315

  15. Richard Krikler commented on patch set 11 V +1 04/16/26, 12:16

    Reply

    Thank you for the fix/ workaround ❤️

    notification.ts:133 Reply

    Acknowledged
  16. Benjamin Franzke uploaded patch set 12 V +1 07/22/26, 06:40

    Rebase
  17. Benjamin Franzke updated the commit message in patch set 13 07/22/26, 06:42

  18. core-ci voted on patch set 13 V -1 07/22/26, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105149

  19. core-ci voted on patch set 12 V -1 07/22/26, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105146

  20. Benjamin Franzke uploaded patch set 14 V -1 09/15/26, 07:15

  21. core-ci voted on patch set 14 V +1 09/15/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108584

  22. Richard Krikler voted on patch set 14 CR +1 V +1 09/15/26, 07:41

  23. Benjamin Kott voted on patch set 14 CR +1 V +1 09/15/26, 07:47

  24. Benjamin Franzke voted on patch set 14 CR +2 V +2 09/15/26, 07:48

  25. Benjamin Franzke merged patch set 15 09/15/26, 08:23