Review main Merged

93252[BUGFIX] Fix docheader buttons alignment when left column is empty

Oli Bartsch CR +2 V +2 Easy +9 −4 updated 03/23/26, 13:28

Commit message

Add margin-inline-start: auto to the last docheader
column to ensure right-aligned buttons stay on the
right even when the left column is hidden.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1417

  1. Oli Bartsch uploaded patch set 1 03/18/26, 15:59

  2. core-ci voted on patch set 1 V +1 03/18/26, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98208

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 03/18/26, 17:00

  4. Benjamin Franzke commented on patch set 1 03/18/26, 17:05

    _module.scss:98

    @benjamin.kott@outlook.com this basically broke because of `.module-docheader-column&:not(:has(> *)) { display: none; }` in https://review.typo3.org/c/Packages/TYPO3.CMS/+/92953/7/Build/Sources/Sass/component/_module.scss#89 Do you know if that `display: none` is really needed or can be avoided differently? (Context: I'd like to avoid margin-positioning workarounds inside flex elements, if possible)
  5. Oli Bartsch commented on patch set 1 03/18/26, 17:49

    _module.scss:98 Reply

    Yes, the issue stems from the line you mentioned. I wasn’t sure why it was implemented that way, so I attempted to fix it accordingly. Happy to check again and find a more efficient solution.
  6. Oli Bartsch commented on patch set 1 03/21/26, 08:48

    _module.scss:98 Reply

    are you going to look after this? Otherwise I will go to resolve this comment as the patch fixes the bug.
  7. Benjamin Kott uploaded patch set 2 CR +1 V +1 03/23/26, 11:21

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 03/23/26, 11:21

  9. Benjamin Kott commented on patch set 2 03/23/26, 11:21

    _module.scss:98 Reply

    works for me
  10. Benjamin Franzke commented on patch set 2 CR +1 V +1 03/23/26, 11:22

    _module.scss:98 Reply

    ack, we found no better solution. thanks!
  11. core-ci voted on patch set 2 V -1 03/23/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98458

  12. Benjamin Kott uploaded patch set 3 CR +1 V +1 03/23/26, 12:20

  13. Benjamin Kott voted on patch set 3 CR +1 V +1 03/23/26, 12:21

  14. Benjamin Franzke voted on patch set 3 CR +1 V +1 03/23/26, 12:29

  15. core-ci voted on patch set 3 V +1 03/23/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98474

  16. Benjamin Kott voted on patch set 3 CR +2 V +2 03/23/26, 13:28

  17. Benjamin Kott merged patch set 4 03/23/26, 13:28