Review main Merged

93279[BUGFIX] Add check for editing file metadata in inline relations

Georg Ringer CR +2 V +2 Easy +6 −4 updated 09/19/26, 11:13

Commit message

Check if an editor is able to edit the metadata of a file which might
be prohibited in case of e.g. a readonly storage.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1521

  1. Georg Ringer uploaded patch set 1 03/19/26, 14:49

  2. core-ci voted on patch set 1 V +1 03/19/26, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98239

  3. Georg Ringer commented on patch set 1 03/19/26, 18:20

    This change is ready for review.
  4. Sebastian Michaelsen commented on patch set 1 CR -1 03/20/26, 21:27

    FileReferenceContainer.php:286

    $fileObject can be `null` at this point, right? But the method does not allow null being passed. should the accepted type of the method be `?File` ?
  5. Georg Ringer uploaded patch set 2 CR -1 V +1 03/22/26, 10:20

  6. Georg Ringer commented on patch set 2 03/22/26, 10:20

    if no File object can betr
  7. core-ci voted on patch set 2 V -1 03/22/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98380

  8. Sebastian Michaelsen commented on patch set 2 CR +1 03/22/26, 12:09

    FileReferenceContainer.php:286 Reply

    Done
  9. core-ci commented on patch set 2 03/22/26, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98380

  10. core-ci commented on patch set 2 03/22/26, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98380

  11. Georg Ringer rebased onto patch set 3 CR +1 V -1 03/24/26, 19:21

  12. core-ci voted on patch set 3 V +1 03/24/26, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98622

  13. Sebastian Michaelsen voted on patch set 3 CR +1 V +1 03/24/26, 19:37

  14. Christian Kuhn voted on patch set 3 CR +1 03/24/26, 19:38

  15. Benni Mack updated the commit message in patch set 4 CR +1 V +1 04/22/26, 06:44

  16. core-ci voted on patch set 4 V +1 04/22/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100778

  17. Christian Kuhn wrote 06/18/26, 23:09

    Removed reviewer Christian Kuhn.
  18. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/18/26, 23:02

  19. Benni Mack voted on patch set 4 CR +1 V +1 09/19/26, 07:47

  20. Georg Ringer voted on patch set 4 CR +2 V +2 09/19/26, 11:13

  21. Georg Ringer merged patch set 5 09/19/26, 11:13