Review main Merged

93280[TASK] Use human-readable labels for fe_users extbase type options

Georg Ringer CR +2 V +2 Easy +2 −2 updated 03/23/26, 09:02

Commit message

The fe_users record type field provided by extbase used raw identifiers
as labels — "undefined" for the default type and the full PHP class name
"Tx_Extbase_Domain_Model_FrontendUser" for the extbase model type. Both
are replaced with descriptive labels that are meaningful to editors.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1113

  1. Georg Ringer uploaded patch set 1 03/19/26, 14:56

  2. Georg Ringer commented on patch set 1 03/19/26, 14:57

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/19/26, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98241

  4. Josua Vogel commented on patch set 1 03/19/26, 19:01

    fe_users.php:18

    you can use the new syntax
  5. Georg Ringer commented on patch set 1 03/20/26, 06:32

    fe_users.php:18 Reply

    as the whole file is not yet migrated, I would leave it that way
  6. Josua Vogel voted on patch set 1 CR +1 V +1 03/20/26, 06:40

  7. Garvin Hicking voted on patch set 1 CR +1 V +1 03/20/26, 07:54

  8. Benjamin Kott commented on patch set 1 CR -1 03/23/26, 08:10

    on it
  9. Benjamin Kott uploaded patch set 2 CR +1 V +1 03/23/26, 08:15

  10. core-ci voted on patch set 2 V +1 03/23/26, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98431

  11. Garvin Hicking commented on patch set 2 CR +1 V +1 03/23/26, 08:37

    I've checked back with the localization team: https://typo3.slack.com/archives/CR75200FL/p1774254546418099 Changing the existing label should be "fine" and will trigger re-translation for other languages.
  12. Benjamin Kott voted on patch set 2 CR +2 V +2 03/23/26, 09:01

  13. Benjamin Kott merged patch set 3 03/23/26, 09:02