Review main Merged

93281[TASK] Use eye icons for menu visibility context menu items

Georg Ringer CR +2 V +2 Easy +2 −2 updated 11/09/26, 17:47

Commit message

The page context menu items "Show in menus" and "Hide in menus" use
the icons `actions-eye` and `actions-eye-slash`, which express the
visibility of a page in menus.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1621

  1. Georg Ringer uploaded patch set 1 03/19/26, 19:03

  2. core-ci voted on patch set 1 V -1 03/19/26, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98244

  3. Georg Ringer rebased onto patch set 2 V -1 08/27/26, 17:25

  4. core-ci voted on patch set 2 V +1 08/27/26, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107284

  5. Georg Ringer uploaded patch set 3 V +1 10/02/26, 16:12

  6. Georg Ringer commented on patch set 3 10/02/26, 16:12

    This change is ready for review.
  7. core-ci voted on patch set 3 V +1 10/02/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109970

  8. Georg Ringer uploaded patch set 4 V +1 10/02/26, 16:30

  9. Wouter Wolters voted on patch set 4 CR +1 V +1 10/02/26, 16:34

  10. core-ci voted on patch set 4 V +1 10/02/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109974

  11. Oli Bartsch commented on patch set 4 10/02/26, 19:57

    What do you mean by this? IMO these states have no overlay. There is a dedicated icon "apps-pagetree-page-hideinmenu" for the hidden state.
  12. Georg Ringer commented on patch set 4 10/06/26, 14:05

    Reply

    the hide/show in menu icon depends on the state of the selected page.
  13. Georg Ringer uploaded patch set 5 CR +1 V +1 10/15/26, 20:06

  14. core-ci voted on patch set 5 V +1 10/15/26, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111263

  15. Wouter Wolters voted on patch set 5 CR +1 V +1 10/20/26, 16:46

  16. Georg Ringer commented on patch set 5 11/03/26, 19:38

    Reply

    Done
  17. Josua Vogel voted on patch set 5 CR +1 V +1 11/05/26, 07:54

  18. Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/05/26, 09:38

  19. Oli Bartsch voted on patch set 5 CR -2 11/06/26, 09:53

  20. Oli Bartsch voted on patch set 5 CR +2 V +2 11/09/26, 17:47

  21. Oli Bartsch merged patch set 6 11/09/26, 17:47