93283[TASK] Deprecate setLogTable()/getLogTable() in DatabaseWriter
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Log/Writer/DatabaseWriter.php+14 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst5new+103 −0
- typo3/sysext/core/Tests/Unit/Log/Writer/DatabaseWriterTest.php+8 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
Review log 1925
-
Sebastian Michaelsen uploaded patch set 1 03/19/26, 20:53
-
Sebastian Michaelsen updated the commit message in patch set 2 03/19/26, 20:54
-
Garvin Hicking commented on patch set 2 03/19/26, 20:56
-
core-ci voted on patch set 2 V +1 03/19/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98248
-
core-ci voted on patch set 1 V -1 03/19/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98247
-
Sebastian Michaelsen updated the commit message in patch set 3
V +103/20/26, 05:48 -
core-ci voted on patch set 3 V +1 03/20/26, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98264
-
Sebastian Michaelsen uploaded patch set 4
V +103/20/26, 08:15 -
Sebastian Michaelsen commented on patch set 3 03/20/26, 08:16
Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:97ReplyI implemented a scanner, but it won't find the probably most common use case: having the custom table configured via logging framework configuration. only direct calls to the setter and getter are detected. -
Sebastian Michaelsen updated the commit message in patch set 5 03/20/26, 08:16
-
core-ci voted on patch set 4 V +1 03/20/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98266
-
Markus Klein voted on patch set 5 CR +1 V +1 03/20/26, 08:29
-
Oliver Klee voted on patch set 5 CR +1 V +1 03/20/26, 08:34
-
core-ci voted on patch set 5 V +1 03/20/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98267
-
Stefan Bürk commented on patch set 5 CR -1 03/20/26, 09:33
-1 commit message exceeding line lengths. -
Sebastian Michaelsen updated the commit message in patch set 6
CR +1V +103/20/26, 10:02 -
Sebastian Michaelsen commented on patch set 5 03/20/26, 10:02
Reply
Done -
Oliver Klee voted on patch set 6 CR +1 V +1 03/20/26, 10:07
-
core-ci voted on patch set 6 V +1 03/20/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98284
-
Markus Klein voted on patch set 6 CR +1 V +1 03/20/26, 19:54
-
Georg Ringer commented on patch set 6 CR +1 V +1 03/20/26, 20:35
Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103isn't it fullyscanned? 2 methods deprecated, both checked -
Sebastian Michaelsen commented on patch set 6 03/20/26, 20:41
Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103ReplyThe problem is that if someone uses a custom table, they likely don't use the setter directly but set it as option in the logging framework configuration. AbstractWriter then "magically" calls setter methods for those options. That case is not scanned. -
Georg Ringer voted on patch set 6 CR +2 V +2 03/21/26, 20:44
-
Georg Ringer merged patch set 7 03/21/26, 20:44
-
Christian Kuhn commented on patch set 7 06/01/26, 23:13
Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103ReplyDone
Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:97