Review main Merged

93283[TASK] Deprecate setLogTable()/getLogTable() in DatabaseWriter

Sebastian Michaelsen CR +2 V +2 Normal +139 −0 updated 06/01/26, 23:13

Commit message

Setting their own table does not give the user a lot of flexibility,
because that custom table needs to largely resemble sys_log. Using a
custom writer offers real flexibility instead.

For TYPO3 the possibility to set other tables, makes it near impossible
to make meaningful changes to DatabaseWriter without introducing
breaking changes.

The possibility to set a custom table is therefore deprecated with the
goal to make DatabaseWriter locked to sys_log in TYPO3 v15.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1925

  1. Sebastian Michaelsen uploaded patch set 1 03/19/26, 20:53

  2. Sebastian Michaelsen updated the commit message in patch set 2 03/19/26, 20:54

  3. Garvin Hicking commented on patch set 2 03/19/26, 20:56

    Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:97

    I think we could add Scanner usage implementation here with classname matches to AbstractWriter
  4. core-ci voted on patch set 2 V +1 03/19/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98248

  5. core-ci voted on patch set 1 V -1 03/19/26, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98247

  6. Sebastian Michaelsen updated the commit message in patch set 3 V +1 03/20/26, 05:48

  7. core-ci voted on patch set 3 V +1 03/20/26, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98264

  8. Sebastian Michaelsen uploaded patch set 4 V +1 03/20/26, 08:15

  9. Sebastian Michaelsen commented on patch set 3 03/20/26, 08:16

    Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:97 Reply

    I implemented a scanner, but it won't find the probably most common use case: having the custom table configured via logging framework configuration. only direct calls to the setter and getter are detected.
  10. Sebastian Michaelsen updated the commit message in patch set 5 03/20/26, 08:16

  11. core-ci voted on patch set 4 V +1 03/20/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98266

  12. Markus Klein voted on patch set 5 CR +1 V +1 03/20/26, 08:29

  13. Oliver Klee voted on patch set 5 CR +1 V +1 03/20/26, 08:34

  14. core-ci voted on patch set 5 V +1 03/20/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98267

  15. Stefan Bürk commented on patch set 5 CR -1 03/20/26, 09:33

    -1 commit message exceeding line lengths.
  16. Sebastian Michaelsen updated the commit message in patch set 6 CR +1 V +1 03/20/26, 10:02

  17. Sebastian Michaelsen commented on patch set 5 03/20/26, 10:02

    Reply

    Done
  18. Oliver Klee voted on patch set 6 CR +1 V +1 03/20/26, 10:07

  19. core-ci voted on patch set 6 V +1 03/20/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98284

  20. Markus Klein voted on patch set 6 CR +1 V +1 03/20/26, 19:54

  21. Georg Ringer commented on patch set 6 CR +1 V +1 03/20/26, 20:35

    Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103

    isn't it fullyscanned? 2 methods deprecated, both checked
  22. Sebastian Michaelsen commented on patch set 6 03/20/26, 20:41

    Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103 Reply

    The problem is that if someone uses a custom table, they likely don't use the setter directly but set it as option in the logging framework configuration. AbstractWriter then "magically" calls setter methods for those options. That case is not scanned.
  23. Georg Ringer voted on patch set 6 CR +2 V +2 03/21/26, 20:44

  24. Georg Ringer merged patch set 7 03/21/26, 20:44

  25. Christian Kuhn commented on patch set 7 06/01/26, 23:13

    Deprecation-109295-DatabaseWriterSetLogTableGetLogTable.rst:103 Reply

    Done