Review main Merged

93288[TASK] Integrate virtual app package into package manager

Helmut Hummel CR +2 V +2 Hard +173 −102 updated 03/23/26, 21:14

Commit message

In order to allow TYPO3 code and configuration
to reference resources in the typo3/app package
the system resource API introduced a virtual app package,
which was instantiated on the fly
when resolving system resources.

This clunky workaround can be cleaned up, by integrating this
package into the package manager as (almost) regular package.

The package can be now discovered by the package manager,
but is still hidden from active packages by default.

By doing so, all package resources can be cached alongside
the package itself, which for now isn't a big deal,
but at least avoids some lookups regarding the extension
icons.

This is a preparatory change to also allow arbitrary public
resources to be configured for extensions and the app
package, which will be an important requirement
for theme overrides without the need to create an extension.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Garvin Hicking +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1720

  1. Helmut Hummel uploaded patch set 1 03/20/26, 12:13

  2. Helmut Hummel voted on patch set 1 CR -2 03/20/26, 12:14

  3. Helmut Hummel marked it work in progress 03/20/26, 12:14

  4. core-ci voted on patch set 1 V -1 03/20/26, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98288

  5. Helmut Hummel uploaded patch set 2 V -1 03/23/26, 08:36

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Helmut Hummel commented on patch set 2 CR 0 03/23/26, 08:37

    This change is ready for review.
  7. Georg Ringer voted on patch set 2 CR +1 V +1 03/23/26, 08:45

  8. core-ci voted on patch set 2 V -1 03/23/26, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98433

  9. Helmut Hummel uploaded patch set 3 CR +1 V +1 03/23/26, 08:58

  10. Georg Ringer voted on patch set 3 CR +1 V +1 03/23/26, 09:01

  11. Helmut Hummel commented on patch set 3 03/23/26, 09:02

    sorry for the hassle folks. making the path relative was missing for the app package previously: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93288/1..3
  12. core-ci voted on patch set 3 V +1 03/23/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98435

  13. Garvin Hicking commented on patch set 3 CR +1 03/23/26, 09:29

    PackageManager.php:152 Unresolved

    Should we encapsulate this in a specific (private) method like "registerVirtualAppPackage()"?
  14. Benjamin Franzke voted on patch set 3 CR +1 03/23/26, 09:34

  15. Benjamin Franzke commented on patch set 3 V +1 03/23/26, 09:50

    PackageManager.php:637

    Just flipped this to `true` (for testing the effects), looks good so far 👍 Small offtopic question (not relevant for merging): Do you already have plans to enable this by default at some point?
  16. Simon Praetorius commented on patch set 3 V -1 03/23/26, 11:49

    will test later with vite extension
  17. Simon Praetorius voted on patch set 3 CR +1 V +1 03/23/26, 19:40

  18. Helmut Hummel voted on patch set 3 CR +2 V +2 03/23/26, 21:02

  19. Helmut Hummel merged patch set 4 03/23/26, 21:03

  20. Christian Kuhn commented on patch set 3 03/23/26, 21:14

    Unresolved

    We can do https://github.com/TYPO3/testing-framework/pull/710 after core merge to raise TF in core-main afterwards?