93288[TASK] Integrate virtual app package into package manager
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Georg Ringer +1
- Garvin Hicking +1
- Simon Praetorius +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benjamin Franzke +1
- Georg Ringer +1
- Simon Praetorius +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+4 −1
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php+20 −1
- typo3/sysext/core/Classes/Core/Environment.php+4 −2
- typo3/sysext/core/Classes/Localization/LanguagePackService.php+4 −1
- typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php+6 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheInterface.php+3 −0
- typo3/sysext/core/Classes/Package/Resource/ResourceCollection.php+19 −21
- typo3/sysext/core/Classes/Package/Resource/ResourceCollectionInterface.php+4 −4
- typo3/sysext/core/Classes/Package/Package.php+9 −4
- typo3/sysext/core/Classes/Package/PackageManager.php2+23 −11
- typo3/sysext/core/Classes/Package/VirtualAppPackage.phpnew+47 −0
- typo3/sysext/core/Classes/SystemResource/Identifier/SystemResourceIdentifierFactory.php+2 −6
- typo3/sysext/core/Classes/SystemResource/Package/AppResourceCollection.phprenamed+4 −5
- typo3/sysext/core/Classes/SystemResource/Package/VirtualAppPackage.phpdeleted+0 −43
- typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+2 −0
- typo3/sysext/core/Tests/Unit/SystemResource/Identifier/SystemResourceIdentifierFactoryTest.php+7 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+5 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+9 −1
Review log 1720
-
Helmut Hummel uploaded patch set 1 03/20/26, 12:13
-
Helmut Hummel voted on patch set 1 CR -2 03/20/26, 12:14
-
Helmut Hummel marked it work in progress 03/20/26, 12:14
-
core-ci voted on patch set 1 V -1 03/20/26, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98288
-
Helmut Hummel uploaded patch set 2
V -103/23/26, 08:36Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Helmut Hummel commented on patch set 2 CR 0 03/23/26, 08:37
This change is ready for review. -
Georg Ringer voted on patch set 2 CR +1 V +1 03/23/26, 08:45
-
core-ci voted on patch set 2 V -1 03/23/26, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98433
-
Helmut Hummel uploaded patch set 3
CR +1V +103/23/26, 08:58 -
Georg Ringer voted on patch set 3 CR +1 V +1 03/23/26, 09:01
-
Helmut Hummel commented on patch set 3 03/23/26, 09:02
sorry for the hassle folks. making the path relative was missing for the app package previously: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93288/1..3 -
core-ci voted on patch set 3 V +1 03/23/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98435
-
Garvin Hicking commented on patch set 3 CR +1 03/23/26, 09:29
PackageManager.php:152UnresolvedShould we encapsulate this in a specific (private) method like "registerVirtualAppPackage()"? -
Benjamin Franzke voted on patch set 3 CR +1 03/23/26, 09:34
-
Benjamin Franzke commented on patch set 3 V +1 03/23/26, 09:50
PackageManager.php:637Just flipped this to `true` (for testing the effects), looks good so far 👍 Small offtopic question (not relevant for merging): Do you already have plans to enable this by default at some point? -
Simon Praetorius commented on patch set 3 V -1 03/23/26, 11:49
will test later with vite extension -
Simon Praetorius voted on patch set 3 CR +1 V +1 03/23/26, 19:40
-
Helmut Hummel voted on patch set 3 CR +2 V +2 03/23/26, 21:02
-
Helmut Hummel merged patch set 4 03/23/26, 21:03
-
Christian Kuhn commented on patch set 3 03/23/26, 21:14
Unresolved
We can do https://github.com/TYPO3/testing-framework/pull/710 after core merge to raise TF in core-main afterwards?