Review main Merged

93295[BUGFIX] Respect Site::isTypoScriptRoot() in BackendConfigurationManager

Sebastian Michaelsen CR +2 V +2 Normal +57 −1 updated 04/08/26, 06:54

Commit message

When a site has `isTypoScriptRoot() === true`, the frontend's
`PageInformationFactory` truncates the rootline to the site root
page before passing it to `SysTemplateRepository`. This ensures
`sys_template` records from parent sites are not included.

`BackendConfigurationManager::getTypoScriptSetup()` passed the full
global rootline to `SysTemplateRepository` unconditionally, picking
up sys_template records outside the current site scope. Apply the
same truncation logic as the frontend when `isTypoScriptRoot()` is
true. The full rootline is still used for expression matcher
variables.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sebastian Michaelsen +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Sebastian Michaelsen +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1421

  1. Sebastian Michaelsen uploaded patch set 1 03/21/26, 05:58

  2. core-ci voted on patch set 1 V -1 03/21/26, 06:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98332

  3. Sebastian Michaelsen uploaded patch set 2 V -1 03/21/26, 06:10

  4. core-ci voted on patch set 2 V +1 03/21/26, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98333

  5. Oliver Klee voted on patch set 2 V +1 03/21/26, 09:39

  6. Oliver Klee updated the commit message in patch set 3 V +1 03/21/26, 09:42

  7. Oliver Klee voted on patch set 3 V +1 03/21/26, 09:42

  8. core-ci voted on patch set 3 V -1 03/21/26, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98338

  9. core-ci commented on patch set 3 03/21/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98338

  10. core-ci commented on patch set 3 03/21/26, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98338

  11. Oliver Klee voted on patch set 3 V 0 03/21/26, 12:02

  12. core-ci voted on patch set 3 V +1 03/21/26, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98338

  13. Oliver Klee voted on patch set 3 V +1 03/21/26, 18:11

  14. Garvin Hicking uploaded patch set 4 V +1 03/24/26, 07:21

  15. Garvin Hicking voted on patch set 4 CR +1 V +1 03/24/26, 07:21

  16. Sebastian Michaelsen voted on patch set 4 CR +1 V +1 03/24/26, 07:28

  17. core-ci voted on patch set 4 V +1 03/24/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98536

  18. Stefan Bürk commented on patch set 4 CR -1 03/24/26, 22:07

    Reviewing ...
  19. Stefan Bürk commented on patch set 4 CR 0 03/31/26, 08:51

    Reply

    Done
  20. Georg Ringer voted on patch set 4 CR +2 V +2 04/08/26, 06:54

  21. Georg Ringer merged patch set 5 04/08/26, 06:54