Review main Merged

93296[BUGFIX] Exclude missing files from FAL metadata extraction batch

Sebastian Michaelsen CR +2 V +2 Normal +62 −1 updated 03/22/26, 07:35

Commit message

Add a `missing = 0` filter to the query in
`FileIndexRepository::findInStorageWithIndexOutstanding()`.

Previously, sys_file records marked as missing=1 were included
in the batch query result, consuming slots from the configurable
batch limit without performing useful work. When enough orphan
records exist, valid but unindexed files are never reached and
their metadata is never extracted.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 512

  1. Sebastian Michaelsen uploaded patch set 1 03/21/26, 07:57

  2. Sebastian Michaelsen uploaded patch set 2 03/21/26, 08:00

  3. core-ci voted on patch set 1 V +1 03/21/26, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98334

  4. core-ci voted on patch set 2 V -1 03/21/26, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 03/21/26, 09:49

    Nice one, and great you added a test for it. Failing test is flakey e2e which I've restarted now.
  6. core-ci commented on patch set 2 03/21/26, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  7. core-ci commented on patch set 2 03/21/26, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  8. core-ci commented on patch set 2 03/21/26, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  9. core-ci commented on patch set 2 03/21/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  10. core-ci voted on patch set 2 V +1 03/21/26, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98335

  11. Georg Ringer voted on patch set 2 CR +2 V +2 03/22/26, 07:34

  12. Georg Ringer merged patch set 3 03/22/26, 07:35