Review main Merged

93309[BUGFIX] Do not resolve subschema name for empty type values

Benjamin Kott CR +2 V +2 Easy +8 −6 updated 03/23/26, 09:01

Commit message

When a record has an empty type field value, the code previously
attempted to resolve a label via `getLabelFromItemlist` and the
subschema title. This could produce incorrect labels for records
that intentionally have no type set, such as placeholders. The
resolution logic is now skipped entirely when the type value is
an empty string.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Benjamin Kott uploaded patch set 1 03/23/26, 08:05

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 03/23/26, 08:06

  3. core-ci voted on patch set 1 V +1 03/23/26, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98428

  4. Benjamin Kott updated the commit message in patch set 2 CR +1 V +1 03/23/26, 08:41

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 03/23/26, 08:42

  6. Josua Vogel voted on patch set 2 CR +1 V +1 03/23/26, 08:50

  7. core-ci voted on patch set 2 V -1 03/23/26, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98434

  8. core-ci voted on patch set 2 V +1 03/23/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98434

  9. Benjamin Kott voted on patch set 2 CR +2 V +2 03/23/26, 09:01

  10. Benjamin Kott merged patch set 3 03/23/26, 09:01