Review main Abandoned

93312[TASK] Temporarily disable flaky Playwright e2e tests

Simon Schaufelberger CR -1 V -1 Easy +10 −11 updated 03/24/26, 09:49

Commit message

These 3 tests cause the most trouble and are disabled until someone will
take a look at them why they cause failures too often.

Review

  • Code review CR -1
    • Georg Ringer +1
    • Oliver Klee +1
    • Josua Vogel +1
    • Sven Liebert -1
    • Benjamin Kott -1
  • Verified V -1
    • Georg Ringer +1
    • Oliver Klee +1
    • Josua Vogel +1
    • Sven Liebert -1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2830

Show 45 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 03/23/26, 10:28

  2. Josua Vogel commented on patch set 1 03/23/26, 10:31

  3. core-ci voted on patch set 1 V +1 03/23/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98448

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 03/23/26, 10:42

    I cant take the gailing
  5. Simon Schaufelberger uploaded patch set 2 CR +1 V +1 03/23/26, 10:43

  1. Simon Schaufelberger commented on patch set 2 03/23/26, 10:44

    Reply

    great idea!
  2. Simon Schaufelberger uploaded patch set 3 03/23/26, 10:44

  3. Mathias Brodala commented on patch set 3 03/23/26, 11:07

    qrcode-module.spec.ts:10

    You can use test.fixme() before the 1st test to have all tests in this file skipped.

    bookmark.spec.ts:11

    See above, this time all testes in this test.describe() block can be skipped with a single test.fixme()
  4. Simon Schaufelberger commented on patch set 3 03/23/26, 11:14

    qrcode-module.spec.ts:10 Reply

    but this will make it easier to enable individual tests again
  5. Mathias Brodala commented on patch set 3 03/23/26, 11:16

    qrcode-module.spec.ts:10 Reply

    Sure, also fine with me. Just wanted make sure it was mentioned.
  6. Simon Schaufelberger commented on patch set 3 03/23/26, 11:17

    bookmark.spec.ts:11 Reply

    Done
  7. Garvin Hicking voted on patch set 3 CR +1 V +1 03/23/26, 11:20

  8. core-ci voted on patch set 3 V +1 03/23/26, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98450

  9. Georg Ringer voted on patch set 3 CR +1 V +1 03/23/26, 11:41

  10. Josua Vogel voted on patch set 3 CR +1 V +1 03/23/26, 11:46

  11. Benjamin Franzke commented on patch set 3 03/23/26, 12:00

    open-in-new-window-language-switching.spec.ts:4

    Hey, `text.fixme` is intended for tests that crash. [1] `test.fail` could be used to denote patches that are expected to fail, but will be run nonetheless. That mean we can see what's going on in the logs, which might be helpful to fix these issues in future. [1] https://playwright.dev/docs/test-annotations#introduction > test.fail() marks the test as failing. Playwright will run this test and ensure it does indeed fail. If the test does not fail, Playwright will complain. > test.fixme() marks the test as failing. Playwright will not run this test, as opposed to the fail annotation. Use fixme when running the test is slow or crashes.
  12. Josua Vogel commented on patch set 3 03/23/26, 12:03

    open-in-new-window-language-switching.spec.ts:4 Reply

    "test.fail() marks the test as failing. Playwright will run this test and ensure it does indeed fail. If the test does not fail, Playwright will complain." I think sometimes the test does not fail, so it will complain
  13. Benjamin Franzke commented on patch set 3 03/23/26, 12:04

    open-in-new-window-language-switching.spec.ts:4 Reply

    you're right, ack.
  14. Sven Liebert voted on patch set 3 CR +1 V +1 03/23/26, 13:04

  15. Oliver Klee voted on patch set 3 CR +1 V +1 03/23/26, 13:10

  16. Benjamin Kott commented on patch set 3 CR -1 03/23/26, 14:01

    i prefer this not to be merged, working on stabilization
  17. Simon Schaufelberger commented on patch set 3 03/23/26, 14:03

    Reply

    it would have been good to tell us that you do that already last week.
  18. Simon Praetorius commented on patch set 3 03/23/26, 14:34

    Reply

    @simonschaufi+typo3@gmail.com There's really no need to be snarky here. Please don't talk to others like that!
  19. Garvin Hicking commented on patch set 3 03/23/26, 14:48

    Reply

    I read Benjis statement so that he'll "now start working on it", not "past tense". And I agree with Simon P. This is a frustrating topic and I try to contain myself (with little success), but no ad hominems please.
  20. Simon Schaufelberger commented on patch set 3 03/23/26, 15:06

    Reply

    @benjamin.kott@outlook.com ok, let me know if it works out and you are successful. If not, can we use this patch as a temporary "solution" to stabilize the CI?
  21. Garvin Hicking commented on patch set 3 CR 0 V 0 03/23/26, 15:12

  22. Benjamin Kott commented on patch set 3 03/23/26, 16:26

    Reply Unresolved

    @simonschaufi+typo3@gmail.com i started working on it today. looks promising, pipelines keep green, still have some retries here and then, trying to smooth them out.
  23. Sven Liebert voted on patch set 3 CR 0 V 0 03/24/26, 06:39

  24. Sven Liebert voted on patch set 3 CR -1 V -1 03/24/26, 06:39

  25. Garvin Hicking abandoned the change 03/24/26, 09:49