Review main Merged

93313[BUGFIX] Fix site_language icons in site config

Bastien Lutz CR +2 V +2 Normal +43 −35 updated 03/24/26, 18:25

Commit message

The icons were broken as $GLOBALS['TCA'] is not mocked
anymore. The IconFactory must also use tca schema instead
of accessing $GLOBALS['TCA']. To fix that, it is now possible
to provide a tca schema. A fallback the schema is fetched
from the schema api.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1926

Show 1 earlier messages
  1. Bastien Lutz uploaded patch set 1 03/23/26, 11:06

  1. core-ci voted on patch set 1 V -1 03/23/26, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98456

  2. Bastien Lutz uploaded patch set 2 V -1 03/23/26, 13:26

  3. core-ci voted on patch set 2 V -1 03/23/26, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98484

  4. Bastien Lutz uploaded patch set 3 03/23/26, 14:15

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  5. core-ci voted on patch set 3 V +1 03/23/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98489

  6. Christian Kuhn commented on patch set 3 03/24/26, 09:31

    thank you Bastien! i'm planning for a review today.
  7. Benjamin Franzke uploaded patch set 4 V +1 03/24/26, 12:11

  8. Benjamin Franzke commented on patch set 4 03/24/26, 12:12

    https://forge.typo3.org/issues/107260 is not merged yet, did you mean another change that is responsible (=removed the mocking)?
  9. Christian Kuhn commented on patch set 3 03/24/26, 12:17

    IconFactory.php:83

    lets see if we can switch to DI here easily.
  10. core-ci voted on patch set 4 V +1 03/24/26, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98583

  11. Christian Kuhn commented on patch set 4 03/24/26, 12:23

    Reply

    Change https://review.typo3.org/c/Packages/TYPO3.CMS/+/93145 triggered the issue. We missed a Resolves line in its commit message. I'll try to clean this up a bit.
  12. Christian Kuhn uploaded patch set 5 V +1 03/24/26, 12:26

  13. Benjamin Franzke commented on patch set 5 03/24/26, 12:28

    Reply

    ah, kk, thx.
  14. core-ci voted on patch set 5 V -1 03/24/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98584

  15. Christian Kuhn uploaded patch set 6 V -1 03/24/26, 12:42

  16. Christian Kuhn commented on patch set 6 03/24/26, 12:42

    IconFactory.php:83 Reply

    well, not easily since IconFactory is wired into ext:install early. we'll keep the makeInstance() for now.
  17. Christian Kuhn uploaded patch set 7 03/24/26, 12:43

  18. core-ci voted on patch set 6 V -1 03/24/26, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98585

  19. core-ci voted on patch set 7 V +1 03/24/26, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98586

  20. Christian Kuhn voted on patch set 7 CR +1 V +1 03/24/26, 13:01

  21. Garvin Hicking voted on patch set 7 CR +1 V +1 03/24/26, 18:22

  22. Stefan Bürk voted on patch set 7 CR +2 V +2 03/24/26, 18:24

  23. Stefan Bürk voted on patch set 7 CR +1 V +1 03/24/26, 18:24

  24. Christian Kuhn voted on patch set 7 CR +2 V +2 03/24/26, 18:24

  25. Christian Kuhn merged patch set 8 03/24/26, 18:25