93313[BUGFIX] Fix site_language icons in site config
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+4 −4
- typo3/sysext/core/Classes/Imaging/IconFactory.php2+33 −27
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+3 −1
- typo3/sysext/indexed_search/Classes/Hook/AvailableTcaTables.php+1 −1
Review log 1926
Show 1 earlier messages
-
Bastien Lutz uploaded patch set 1 03/23/26, 11:06
-
core-ci voted on patch set 1 V -1 03/23/26, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98456
-
Bastien Lutz uploaded patch set 2
V -103/23/26, 13:26 -
core-ci voted on patch set 2 V -1 03/23/26, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98484
-
Bastien Lutz uploaded patch set 3 03/23/26, 14:15
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 3 V +1 03/23/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98489
-
Christian Kuhn commented on patch set 3 03/24/26, 09:31
thank you Bastien! i'm planning for a review today. -
Benjamin Franzke uploaded patch set 4
V +103/24/26, 12:11 -
Benjamin Franzke commented on patch set 4 03/24/26, 12:12
https://forge.typo3.org/issues/107260 is not merged yet, did you mean another change that is responsible (=removed the mocking)? -
Christian Kuhn commented on patch set 3 03/24/26, 12:17
IconFactory.php:83lets see if we can switch to DI here easily. -
core-ci voted on patch set 4 V +1 03/24/26, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98583
-
Christian Kuhn commented on patch set 4 03/24/26, 12:23
Reply
Change https://review.typo3.org/c/Packages/TYPO3.CMS/+/93145 triggered the issue. We missed a Resolves line in its commit message. I'll try to clean this up a bit. -
Christian Kuhn uploaded patch set 5
V +103/24/26, 12:26 -
Benjamin Franzke commented on patch set 5 03/24/26, 12:28
Reply
ah, kk, thx. -
core-ci voted on patch set 5 V -1 03/24/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98584
-
Christian Kuhn uploaded patch set 6
V -103/24/26, 12:42 -
Christian Kuhn commented on patch set 6 03/24/26, 12:42
IconFactory.php:83Replywell, not easily since IconFactory is wired into ext:install early. we'll keep the makeInstance() for now. -
Christian Kuhn uploaded patch set 7 03/24/26, 12:43
-
core-ci voted on patch set 6 V -1 03/24/26, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98585
-
core-ci voted on patch set 7 V +1 03/24/26, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98586
-
Christian Kuhn voted on patch set 7 CR +1 V +1 03/24/26, 13:01
-
Garvin Hicking voted on patch set 7 CR +1 V +1 03/24/26, 18:22
-
Stefan Bürk voted on patch set 7 CR +2 V +2 03/24/26, 18:24
-
Stefan Bürk voted on patch set 7 CR +1 V +1 03/24/26, 18:24
-
Christian Kuhn voted on patch set 7 CR +2 V +2 03/24/26, 18:24
-
Christian Kuhn merged patch set 8 03/24/26, 18:25