Review main Merged

93316[TASK] Add permission checks to PageWizardController

Andreas Nedbal CR +2 V +2 Normal +128 −41 updated 03/27/26, 14:00

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Bastien Lutz +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Bastien Lutz +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2639

Show 714 earlier messages
  1. Andreas Nedbal uploaded patch set 1 03/23/26, 13:02

  2. core-ci voted on patch set 1 V -1 03/23/26, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98479

  3. Andreas Nedbal rebased onto patch set 2 V -1 03/25/26, 10:36

  4. core-ci voted on patch set 2 V -1 03/25/26, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98673

  5. Oli Bartsch commented on patch set 2 03/25/26, 11:15

    PageWizardController.php:66

    As noted in the review of the initial patch, this approach does not seem right here. What is the reason for using the repository instead of the backend utility methods?
  6. Andreas Nedbal uploaded patch set 3 V -1 03/25/26, 12:51

  7. core-ci voted on patch set 3 V -1 03/25/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98697

  8. Andreas Nedbal uploaded patch set 4 V -1 03/25/26, 14:02

  9. Andreas Nedbal uploaded patch set 5 03/25/26, 14:04

  10. core-ci voted on patch set 5 V -1 03/25/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98703

  11. core-ci voted on patch set 4 V -1 03/25/26, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98702

  12. Andreas Nedbal uploaded patch set 6 V -1 03/25/26, 15:09

  13. core-ci voted on patch set 6 V -1 03/25/26, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707

  14. core-ci commented on patch set 6 03/25/26, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707

  1. core-ci voted on patch set 6 V +1 03/25/26, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707

  2. Bastien Lutz voted on patch set 6 CR +1 03/25/26, 15:45

  3. Andreas Nedbal commented on patch set 6 03/25/26, 16:08

    PageWizardController.php:66 Reply

    Done
  4. Tobias Wojtylak voted on patch set 6 CR +1 03/25/26, 16:11

  5. Benjamin Franzke commented on patch set 6 V -1 03/26/26, 12:42

    With patchset 6 I see no message for the user being printed: See https://forge.typo3.org/issues/109324#note-7 for a screenshot. It stops at step 2 with no message. Console logs "Failed to fetch doktypes". Can be improve this? We should also hide the "+ Page" button in this case.
  6. Tobias Wojtylak uploaded patch set 7 CR +1 V +1 03/26/26, 15:34

  7. core-ci voted on patch set 7 V +1 03/26/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98797

  8. Tobias Wojtylak commented on patch set 7 03/26/26, 15:56

    Reply

    The "+ Page" button is now only displayed if there are doktypes. Is that correct? I attached a screenshot to the ticket showing the wizard state when the server does not return any doktypes.
  9. Benjamin Franzke commented on patch set 7 CR +1 V +1 03/26/26, 19:13

    Reply

    Yes, looks good, thanks! For everyone wondering how to test this error case (which should actually not happen since the "+ Page" button is hidden) The wizard can still be opened via browser console: ``` top.document.querySelector('typo3-backend-navigation-component-pagetree-toolbar').launchPageWizard() ```
  10. Benjamin Franzke uploaded patch set 8 CR +1 V +1 03/27/26, 10:10

  11. core-ci voted on patch set 8 V +1 03/27/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98852

  12. Benjamin Kott commented on patch set 8 03/27/26, 11:32

    PageWizardController.php:129

    why no 403 here?

    PageWizardController.php:149

    why no 403 here?
  13. Andreas Nedbal uploaded patch set 9 CR +1 V +1 03/27/26, 12:27

  14. Andreas Nedbal commented on patch set 9 03/27/26, 12:27

    PageWizardController.php:129 Reply

    Done

    PageWizardController.php:149 Reply

    Done
  15. Benjamin Franzke commented on patch set 9 03/27/26, 12:56

    pages.php:684

    Was this a test, or actually intended?
  16. Andreas Nedbal uploaded patch set 10 03/27/26, 13:02

  17. Andreas Nedbal commented on patch set 10 03/27/26, 13:03

    pages.php:684 Reply

    Was a test leftover!
  18. core-ci voted on patch set 9 V -1 03/27/26, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98864

  19. Andreas Nedbal uploaded patch set 11 03/27/26, 13:22

  20. Benjamin Franzke voted on patch set 11 CR +1 V +1 03/27/26, 13:38

  21. core-ci voted on patch set 10 V -1 03/27/26, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98874

  22. core-ci voted on patch set 11 V +1 03/27/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98879

  23. Bastien Lutz voted on patch set 11 CR +1 V +1 03/27/26, 13:52

  24. Andreas Nedbal voted on patch set 11 CR +2 V +2 03/27/26, 14:00

  25. Andreas Nedbal merged patch set 12 03/27/26, 14:00