93316[TASK] Add permission checks to PageWizardController
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Bastien Lutz +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Bastien Lutz +1
- core-ci +1 CI
Issues 2
Files 12
- Build/Sources/TypeScript/backend/page-wizard/steps/doktype-step.ts+5 −10
- Build/Sources/TypeScript/backend/page-wizard/steps/position-step.ts+1 −1
- Build/Sources/TypeScript/backend/page-wizard/page-wizard.ts+3 −0
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+13 −12
- typo3/sysext/backend/Classes/Controller/Wizard/PageWizardController.php6+23 −6
- typo3/sysext/backend/Resources/Private/Language/Wizards/page.xlf+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/steps/doktype-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/steps/position-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/page-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Wizard/PageWizardControllerTest.php+73 −8
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+3 −0
Review log 2639
Show 714 earlier messages
-
Andreas Nedbal uploaded patch set 1 03/23/26, 13:02
-
core-ci voted on patch set 1 V -1 03/23/26, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98479
-
Andreas Nedbal rebased onto patch set 2
V -103/25/26, 10:36 -
core-ci voted on patch set 2 V -1 03/25/26, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98673
-
Oli Bartsch commented on patch set 2 03/25/26, 11:15
-
Andreas Nedbal uploaded patch set 3
V -103/25/26, 12:51 -
core-ci voted on patch set 3 V -1 03/25/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98697
-
Andreas Nedbal uploaded patch set 4
V -103/25/26, 14:02 -
Andreas Nedbal uploaded patch set 5 03/25/26, 14:04
-
core-ci voted on patch set 5 V -1 03/25/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98703
-
core-ci voted on patch set 4 V -1 03/25/26, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98702
-
Andreas Nedbal uploaded patch set 6
V -103/25/26, 15:09 -
core-ci voted on patch set 6 V -1 03/25/26, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707
-
core-ci commented on patch set 6 03/25/26, 15:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707
-
core-ci voted on patch set 6 V +1 03/25/26, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98707
-
Bastien Lutz voted on patch set 6 CR +1 03/25/26, 15:45
-
Andreas Nedbal commented on patch set 6 03/25/26, 16:08
PageWizardController.php:66ReplyDone -
Tobias Wojtylak voted on patch set 6 CR +1 03/25/26, 16:11
-
Benjamin Franzke commented on patch set 6 V -1 03/26/26, 12:42
With patchset 6 I see no message for the user being printed: See https://forge.typo3.org/issues/109324#note-7 for a screenshot. It stops at step 2 with no message. Console logs "Failed to fetch doktypes". Can be improve this? We should also hide the "+ Page" button in this case. -
Tobias Wojtylak uploaded patch set 7
CR +1V +103/26/26, 15:34 -
core-ci voted on patch set 7 V +1 03/26/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98797
-
Tobias Wojtylak commented on patch set 7 03/26/26, 15:56
Reply
The "+ Page" button is now only displayed if there are doktypes. Is that correct? I attached a screenshot to the ticket showing the wizard state when the server does not return any doktypes. -
Benjamin Franzke commented on patch set 7 CR +1 V +1 03/26/26, 19:13
Reply
Yes, looks good, thanks! For everyone wondering how to test this error case (which should actually not happen since the "+ Page" button is hidden) The wizard can still be opened via browser console: ``` top.document.querySelector('typo3-backend-navigation-component-pagetree-toolbar').launchPageWizard() ``` -
Benjamin Franzke uploaded patch set 8
CR +1V +103/27/26, 10:10 -
core-ci voted on patch set 8 V +1 03/27/26, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98852
-
Benjamin Kott commented on patch set 8 03/27/26, 11:32
PageWizardController.php:129why no 403 here?PageWizardController.php:149why no 403 here? -
Andreas Nedbal uploaded patch set 9
CR +1V +103/27/26, 12:27 -
Andreas Nedbal commented on patch set 9 03/27/26, 12:27
PageWizardController.php:129ReplyDonePageWizardController.php:149ReplyDone -
Benjamin Franzke commented on patch set 9 03/27/26, 12:56
pages.php:684Was this a test, or actually intended? -
Andreas Nedbal uploaded patch set 10 03/27/26, 13:02
-
Andreas Nedbal commented on patch set 10 03/27/26, 13:03
pages.php:684ReplyWas a test leftover! -
core-ci voted on patch set 9 V -1 03/27/26, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98864
-
Andreas Nedbal uploaded patch set 11 03/27/26, 13:22
-
Benjamin Franzke voted on patch set 11 CR +1 V +1 03/27/26, 13:38
-
core-ci voted on patch set 10 V -1 03/27/26, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98874
-
core-ci voted on patch set 11 V +1 03/27/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98879
-
Bastien Lutz voted on patch set 11 CR +1 V +1 03/27/26, 13:52
-
Andreas Nedbal voted on patch set 11 CR +2 V +2 03/27/26, 14:00
-
Andreas Nedbal merged patch set 12 03/27/26, 14:00
PageWizardController.php:66