93318[TASK] Fix flaky Playwright e2e tests
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Garvin Hicking +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/recycler/recycler.ts+15 −2
- Build/tests/playwright/e2e/layout/open-in-new-window-language-switching.spec.ts+11 −5
- Build/tests/playwright/e2e/media/file-clipboard.spec.ts+15 −21
- Build/tests/playwright/e2e/records/sys-note.spec.ts+2 −1
- Build/tests/playwright/e2e/recycler/recycler-module.spec.ts+17 −2
- Build/tests/playwright/e2e/redirects/qrcode-module.spec.ts+10 −7
- Build/tests/playwright/e2e/toolbar/bookmark.spec.ts+4 −2
- Build/tests/playwright/fixtures/doc-header.ts+20 −17
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
Review log 2131
Show 46 earlier messages
-
Benjamin Kott uploaded patch set 1 03/23/26, 14:06
-
core-ci voted on patch set 1 V -1 03/23/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98487
-
Benjamin Kott uploaded patch set 2
V -103/23/26, 14:25 -
core-ci voted on patch set 2 V -1 03/23/26, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98490
-
Christian Kuhn commented on patch set 2 03/23/26, 14:44
It looks as if quite a bit of work happened on https://review.typo3.org/c/Packages/TYPO3.CMS/+/92937 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/91999 already, which aim to solve the same issues and overlap codewise. How to continue with them? -
Benjamin Kott uploaded patch set 3
V -103/23/26, 14:52
-
Benjamin Kott commented on patch set 3 03/23/26, 14:56
Reply
I've seen bennis patch, and also the one from jochen. i for now used the issue from benni to resolve it. But it's really hard to pinpoint the problem. the state i achieved now seems to be more stable at least on the local env. i am currently trying to get them also more stable in the ci env. i just want to prevent the tests to be disabled for now. we can use any existing patch to apply the changes when i am done, but also the solutions are in parts quite different -
core-ci voted on patch set 3 V +1 03/23/26, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98493
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/23/26, 15:12
I take whatever I can get :) -
Benjamin Kott uploaded patch set 4
CR +1V +103/23/26, 15:17 -
Benjamin Kott commented on patch set 4 CR -2 03/23/26, 15:17
the goal is to have 0 retrys -
Benjamin Kott uploaded patch set 5 03/23/26, 15:38
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 5 V +1 03/23/26, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98505
-
core-ci voted on patch set 4 V +1 03/23/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98500
-
Benjamin Kott uploaded patch set 6
V +103/23/26, 15:57Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 6 V +1 03/23/26, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98506
-
Benjamin Kott uploaded patch set 7
V +103/23/26, 16:12Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Kott uploaded patch set 8 03/23/26, 16:20
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 7 V +1 03/23/26, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98507
-
core-ci voted on patch set 8 V -1 03/23/26, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98508
-
core-ci voted on patch set 8 V +1 03/23/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98508
-
Benjamin Kott uploaded patch set 9
V +103/23/26, 17:03Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 9 V +1 03/23/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98512
-
Benjamin Kott voted on patch set 9 CR 0 03/23/26, 18:18
-
Garvin Hicking voted on patch set 9 CR +1 V +1 03/23/26, 18:33
-
Sven Liebert voted on patch set 9 CR +1 V +1 03/24/26, 06:38
-
Georg Ringer voted on patch set 9 CR +2 V +2 03/24/26, 07:06
-
Benni Mack commented on patch set 9 03/24/26, 08:34
Reply
I'll abandon mine, it started off good but AI turned it into a shit-load of workarounds in this case. OK for you @lolli@schwarzbu.ch? -
Oliver Klee voted on patch set 9 V +1 03/24/26, 08:46
-
Garvin Hicking merged patch set 10 03/24/26, 08:56
-
Christian Kuhn commented on patch set 10 03/24/26, 09:06
Reply
thank you benni.