Review main Merged

93320[TASK] Use functional tests for page wizard controllers

Tobias Wojtylak CR +2 V +2 Hard +193 −232 updated 03/25/26, 16:07

Commit message

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2637

Show 712 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 03/23/26, 15:03

  2. Tobias Wojtylak updated the commit message in patch set 2 03/23/26, 15:12

  3. core-ci voted on patch set 1 V -1 03/23/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98495

  4. core-ci voted on patch set 2 V +1 03/23/26, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98498

  5. Tobias Wojtylak marked it ready for review 03/23/26, 16:37

  6. Christian Kuhn commented on patch set 2 03/23/26, 18:49

    WizardControllerTest.php:33

    functional tests must extend from FunctionalTestCase, please.
  7. Tobias Wojtylak uploaded patch set 3 V +1 03/24/26, 07:26

  8. Tobias Wojtylak commented on patch set 2 03/24/26, 07:26

    WizardControllerTest.php:33 Reply

    Done
  9. core-ci voted on patch set 3 V -1 03/24/26, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537

  10. core-ci commented on patch set 3 03/24/26, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537

  11. Benjamin Franzke uploaded patch set 4 V -1 03/24/26, 08:09

  12. core-ci voted on patch set 3 V +1 03/24/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537

  1. core-ci voted on patch set 4 V +1 03/24/26, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98545

  2. Oliver Klee commented on patch set 4 03/24/26, 08:46

    WizardControllerTest.php:35

    As this test does not use any DB, we can add `protected bool $initializeDatabase = false;` to improve performance.
  3. Tobias Wojtylak uploaded patch set 5 CR +1 V +1 03/24/26, 09:47

  4. Tobias Wojtylak uploaded patch set 6 03/24/26, 09:50

  5. core-ci voted on patch set 5 V +1 03/24/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98557

  6. Benjamin Franzke commented on patch set 6 CR +1 V +1 03/24/26, 10:06

    WizardControllerTest.php:35 Reply

    Done
  7. Benjamin Franzke uploaded patch set 7 CR +1 V +1 03/24/26, 10:26

  8. Benjamin Franzke commented on patch set 7 CR +1 V +1 03/24/26, 10:27

    (Rebased on @bastien.lutz@in2code.de's change which we should merge first)
  9. core-ci voted on patch set 6 V +1 03/24/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98558

  10. Christian Kuhn commented on patch set 7 03/24/26, 10:37

    WizardControllerTest.php:18

    location & namespace of test classes should mimic the location of the system under test. in this case, backend/Tests/Functional/Controller/Wizard/WizardControllerTest.php fits.
  11. Christian Kuhn commented on patch set 7 03/24/26, 10:38

    PageWizardControllerTest.php:18

    similar to my other comment: this should be moved one directory down to wizard/, the namespace should reflect this.
  12. Christian Kuhn voted on patch set 7 CR -1 03/24/26, 10:39

  13. Tobias Wojtylak uploaded patch set 8 CR +1 V +1 03/24/26, 10:51

  14. Tobias Wojtylak commented on patch set 8 03/24/26, 11:00

    This change is ready for review.

    PageWizardControllerTest.php:18 Reply

    Done

    WizardControllerTest.php:18 Reply

    Done
  15. Benjamin Franzke voted on patch set 8 CR +1 V +1 03/24/26, 11:06

  16. core-ci voted on patch set 7 V -1 03/24/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98566

  17. core-ci voted on patch set 8 V -1 03/24/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98570

  18. Benjamin Franzke voted on patch set 8 CR 0 V 0 03/24/26, 11:29

  19. Tobias Wojtylak uploaded patch set 9 V -1 03/24/26, 11:35

  20. core-ci voted on patch set 9 V +1 03/24/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98577

  21. Benjamin Franzke voted on patch set 9 CR +1 V +1 03/24/26, 12:04

  22. Oliver Klee voted on patch set 9 V +1 03/24/26, 13:24

  23. Simon Schaufelberger voted on patch set 9 CR +1 V +1 03/24/26, 14:29

  24. Andreas Nedbal voted on patch set 9 CR +2 V +2 03/25/26, 16:07

  25. Andreas Nedbal merged patch set 10 03/25/26, 16:07