93320[TASK] Use functional tests for page wizard controllers
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 3
Review log 2637
Show 712 earlier messages
-
Tobias Wojtylak uploaded patch set 1 03/23/26, 15:03
-
Tobias Wojtylak updated the commit message in patch set 2 03/23/26, 15:12
-
core-ci voted on patch set 1 V -1 03/23/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98495
-
core-ci voted on patch set 2 V +1 03/23/26, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98498
-
Tobias Wojtylak marked it ready for review 03/23/26, 16:37
-
Christian Kuhn commented on patch set 2 03/23/26, 18:49
-
Tobias Wojtylak uploaded patch set 3
V +103/24/26, 07:26 -
Tobias Wojtylak commented on patch set 2 03/24/26, 07:26
WizardControllerTest.php:33ReplyDone -
core-ci voted on patch set 3 V -1 03/24/26, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537
-
core-ci commented on patch set 3 03/24/26, 08:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537
-
Benjamin Franzke uploaded patch set 4
V -103/24/26, 08:09 -
core-ci voted on patch set 3 V +1 03/24/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98537
-
core-ci voted on patch set 4 V +1 03/24/26, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98545
-
Oliver Klee commented on patch set 4 03/24/26, 08:46
WizardControllerTest.php:35As this test does not use any DB, we can add `protected bool $initializeDatabase = false;` to improve performance. -
Tobias Wojtylak uploaded patch set 5
CR +1V +103/24/26, 09:47 -
Tobias Wojtylak uploaded patch set 6 03/24/26, 09:50
-
core-ci voted on patch set 5 V +1 03/24/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98557
-
Benjamin Franzke commented on patch set 6 CR +1 V +1 03/24/26, 10:06
WizardControllerTest.php:35ReplyDone -
Benjamin Franzke uploaded patch set 7
CR +1V +103/24/26, 10:26 -
Benjamin Franzke commented on patch set 7 CR +1 V +1 03/24/26, 10:27
(Rebased on @bastien.lutz@in2code.de's change which we should merge first) -
core-ci voted on patch set 6 V +1 03/24/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98558
-
Christian Kuhn commented on patch set 7 03/24/26, 10:37
WizardControllerTest.php:18location & namespace of test classes should mimic the location of the system under test. in this case, backend/Tests/Functional/Controller/Wizard/WizardControllerTest.php fits. -
Christian Kuhn commented on patch set 7 03/24/26, 10:38
PageWizardControllerTest.php:18similar to my other comment: this should be moved one directory down to wizard/, the namespace should reflect this. -
Christian Kuhn voted on patch set 7 CR -1 03/24/26, 10:39
-
Tobias Wojtylak uploaded patch set 8
CR +1V +103/24/26, 10:51 -
Tobias Wojtylak commented on patch set 8 03/24/26, 11:00
This change is ready for review.PageWizardControllerTest.php:18ReplyDoneWizardControllerTest.php:18ReplyDone -
Benjamin Franzke voted on patch set 8 CR +1 V +1 03/24/26, 11:06
-
core-ci voted on patch set 7 V -1 03/24/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98566
-
core-ci voted on patch set 8 V -1 03/24/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98570
-
Benjamin Franzke voted on patch set 8 CR 0 V 0 03/24/26, 11:29
-
Tobias Wojtylak uploaded patch set 9
V -103/24/26, 11:35 -
core-ci voted on patch set 9 V +1 03/24/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98577
-
Benjamin Franzke voted on patch set 9 CR +1 V +1 03/24/26, 12:04
-
Oliver Klee voted on patch set 9 V +1 03/24/26, 13:24
-
Simon Schaufelberger voted on patch set 9 CR +1 V +1 03/24/26, 14:29
-
Andreas Nedbal voted on patch set 9 CR +2 V +2 03/25/26, 16:07
-
Andreas Nedbal merged patch set 10 03/25/26, 16:07
WizardControllerTest.php:33