Review main Merged

93325[TASK] Lazily instantiate wizard providers

Bastien Lutz CR +2 V +2 Normal +78 −79 updated 03/24/26, 10:30

Commit message

The wizard name is now dervices from the tagged
indem name that can be configured via
`Symfony\Component\DependencyInjection\Attribute\AsTaggedItem`.

The factory is renamed into a registry to better
reflect it's purpose.

Also DataHandler is created on demand instead of being injected,
since it is stateful. Note: The service is not shared, and
the relevant method was only invoked once per request, therefore
this change is not strictly needed, but we prepare for the case
that the invocation sequence ever changes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1621

  1. Bastien Lutz uploaded patch set 1 03/24/26, 09:06

  2. core-ci voted on patch set 1 V -1 03/24/26, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98550

  3. Bastien Lutz uploaded patch set 2 V -1 03/24/26, 09:21

  4. Benjamin Franzke commented on patch set 2 CR -1 03/24/26, 09:29

    I'll try to change this to use `ServiceLocator`s.

    WizardProviderRegistry.php:35

    Injecting an array of all instances will implicitly always enable all instances. We should try to inject a `Symfony\Component\DependencyInjection\ServiceLocator` instance instead, which can be used to lazily instantiate the needed provider in `getProvider()`.

    Services.yaml:84

    I think it was fine to use a tagged iterator based on a tag that was assigned based on an interface. The attribute is not really needed here and therefore does not justify an own compiler pass in my opinion.
  5. core-ci voted on patch set 2 V +1 03/24/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98554

  6. Benjamin Franzke uploaded patch set 3 CR -1 V +1 03/24/26, 09:55

  7. Benjamin Franzke commented on patch set 3 03/24/26, 09:55

    Reply

    Done

    WizardProviderRegistry.php:35 Reply

    Done

    Services.yaml:84 Reply

    Done
  8. Benjamin Franzke voted on patch set 3 V 0 CR -1 03/24/26, 09:59

  9. Benjamin Franzke uploaded patch set 4 CR -1 03/24/26, 10:02

  10. Benjamin Franzke voted on patch set 4 CR +1 V +1 03/24/26, 10:06

  11. Benjamin Franzke uploaded patch set 5 CR +1 V +1 03/24/26, 10:09

  12. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/24/26, 10:09

  13. Bastien Lutz voted on patch set 5 CR +1 V +1 03/24/26, 10:10

  14. Benjamin Franzke uploaded patch set 6 CR +1 V +1 03/24/26, 10:11

  15. core-ci voted on patch set 4 V -1 03/24/26, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98562

  16. core-ci voted on patch set 3 V -1 03/24/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98560

  17. core-ci voted on patch set 6 V +1 03/24/26, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98564

  18. Benjamin Franzke voted on patch set 6 CR +1 V +1 03/24/26, 10:21

  19. Benjamin Kott voted on patch set 6 CR +1 V +1 03/24/26, 10:29

  20. Benjamin Franzke voted on patch set 6 CR +2 V +2 03/24/26, 10:30

  21. Benjamin Franzke merged patch set 7 03/24/26, 10:30