93325[TASK] Lazily instantiate wizard providers
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/backend/Classes/Controller/Wizard/WizardController.php+3 −3
- typo3/sysext/backend/Classes/Wizard/PageWizardProvider.php+9 −12
- typo3/sysext/backend/Classes/Wizard/WizardProviderFactory.phpdeleted+0 −39
- typo3/sysext/backend/Classes/Wizard/WizardProviderInterface.php+10 −2
- typo3/sysext/backend/Classes/Wizard/WizardProviderRegistry.php2new+45 −0
- typo3/sysext/backend/Configuration/Services.yaml2+0 −9
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/WizardControllerTest.php+5 −6
- typo3/sysext/backend/Tests/Unit/Wizard/WizardProviderRegistryTest.phprenamed+6 −8
Review log 1621
-
Bastien Lutz uploaded patch set 1 03/24/26, 09:06
-
core-ci voted on patch set 1 V -1 03/24/26, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98550
-
Bastien Lutz uploaded patch set 2
V -103/24/26, 09:21 -
Benjamin Franzke commented on patch set 2 CR -1 03/24/26, 09:29
I'll try to change this to use `ServiceLocator`s.WizardProviderRegistry.php:35Injecting an array of all instances will implicitly always enable all instances. We should try to inject a `Symfony\Component\DependencyInjection\ServiceLocator` instance instead, which can be used to lazily instantiate the needed provider in `getProvider()`.Services.yaml:84I think it was fine to use a tagged iterator based on a tag that was assigned based on an interface. The attribute is not really needed here and therefore does not justify an own compiler pass in my opinion. -
core-ci voted on patch set 2 V +1 03/24/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98554
-
Benjamin Franzke uploaded patch set 3
CR -1V +103/24/26, 09:55 -
Benjamin Franzke commented on patch set 3 03/24/26, 09:55
Reply
DoneWizardProviderRegistry.php:35ReplyDoneServices.yaml:84ReplyDone -
Benjamin Franzke voted on patch set 3 V 0 CR -1 03/24/26, 09:59
-
Benjamin Franzke uploaded patch set 4
CR -103/24/26, 10:02 -
Benjamin Franzke voted on patch set 4 CR +1 V +1 03/24/26, 10:06
-
Benjamin Franzke uploaded patch set 5
CR +1V +103/24/26, 10:09 -
Benjamin Franzke voted on patch set 5 CR +1 V +1 03/24/26, 10:09
-
Bastien Lutz voted on patch set 5 CR +1 V +1 03/24/26, 10:10
-
Benjamin Franzke uploaded patch set 6
CR +1V +103/24/26, 10:11 -
core-ci voted on patch set 4 V -1 03/24/26, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98562
-
core-ci voted on patch set 3 V -1 03/24/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98560
-
core-ci voted on patch set 6 V +1 03/24/26, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98564
-
Benjamin Franzke voted on patch set 6 CR +1 V +1 03/24/26, 10:21
-
Benjamin Kott voted on patch set 6 CR +1 V +1 03/24/26, 10:29
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 03/24/26, 10:30
-
Benjamin Franzke merged patch set 7 03/24/26, 10:30