Review main Merged

93327[BUGFIX] Prevent empty reference output in TypoScript

Alexander Künzl CR +2 V +2 Normal +175 −21 updated 04/21/26, 15:45

Commit message

When referencing an empty content object and setting values
in the reference, `ContentObjectRenderer` resolves the reference's
identifier instead of its content type, leading to an unknown
content type in the process and an empty output. This commit
allows the usage of an empty object, thus keeping the content
type and allowing the population of the empty object via reference.

Also adds a data provider for the functional test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1621

  1. Alexander Künzl uploaded patch set 1 03/24/26, 12:52

  2. core-ci voted on patch set 1 V -1 03/24/26, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98587

  3. Alexander Künzl uploaded patch set 2 V -1 03/24/26, 13:14

  4. core-ci voted on patch set 2 V +1 03/24/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98589

  5. Stefan Bürk commented on patch set 2 03/24/26, 22:06

    Commit message rules: * Casing subject line * Line length constraints (description block) and also subject line despite slight exceeding allowed to lengthy. See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html See it in more detail -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/93327/2//COMMIT_MSG#9
  6. Alexander Künzl updated the commit message in patch set 3 V +1 03/25/26, 06:52

  7. core-ci voted on patch set 3 V +1 03/25/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98649

  8. Oliver Klee updated the commit message in patch set 4 V +1 03/25/26, 08:43

  9. Oliver Klee commented on patch set 4 03/25/26, 08:43

    Reply

    Done
  10. Oliver Klee commented on patch set 4 03/25/26, 08:44

    Would a backport to 13.4 also make sense? (I haven't checked which versions are affected by the bug yet.)
  11. core-ci voted on patch set 4 V +1 03/25/26, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98662

  12. Christian Kuhn commented on patch set 4 04/21/26, 04:05

    Reply

    v14, v13
  13. Christian Kuhn uploaded patch set 5 V +1 04/21/26, 04:37

  14. core-ci voted on patch set 5 V +1 04/21/26, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100619

  15. Christian Kuhn voted on patch set 5 CR +1 V +1 04/21/26, 04:53

  16. Garvin Hicking voted on patch set 5 CR +1 V +1 04/21/26, 06:36

  17. Oliver Klee voted on patch set 5 CR +1 V +1 04/21/26, 06:51

  18. Helmut Hummel voted on patch set 5 CR +1 V +1 04/21/26, 10:15

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 04/21/26, 15:32

  20. Christian Kuhn merged patch set 6 04/21/26, 15:45