93328[BUGFIX] Ensure correct Grid column width in languageComparisonMode
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Philipp Parzer uploaded patch set 1 03/24/26, 13:49
-
Philipp Parzer commented on patch set 1 03/24/26, 13:52
backport for V13 would be: $this->context->getDrawingConfiguration()->getSelectedLanguageId() <> 0 -
core-ci voted on patch set 1 V +1 03/24/26, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98594
-
Stefan Bürk commented on patch set 1 03/24/26, 21:53
```suggestion [BUGFIX] Fix grid column width in languageComparisonMode ``` Beside, not the first one lately. Usualy we strive not to have online subject commits ony and have more context in the commit message. Using [BUGFIX] Fix .. pesonally I dislike that as this is duplicate and pefere more in one line what is done (that it is a fix is stated by the prefix) for examle: ``` [BUGFIX] Ensure using correct grid column width in langaugeComparsionMode ``` or similar. The descriptive part should explain what was wrong and what the decision was to fix it the way the does it. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html At least recheck casing in subject line. -
Simon Schaufelberger commented on patch set 1 03/24/26, 21:57
Grid.php:69this line is way too long and should be wrapped -
Philipp Parzer uploaded patch set 2
V +103/25/26, 07:28 -
core-ci voted on patch set 2 V +1 03/25/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98653
-
Garvin Hicking updated the commit message in patch set 3
V +103/27/26, 07:59 -
Garvin Hicking commented on patch set 3 03/27/26, 08:07
(Not sure yet how I can reproduce this; it seems related to EXT:container where this codepath is triggered, asked Philipp via slack)Reply
DoneGrid.php:69ReplyDone -
core-ci voted on patch set 3 V +1 03/27/26, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98837
-
Garvin Hicking commented on patch set 3 CR +1 V +1 04/17/26, 10:25
Sorry this took some time. I can verify/reproduce this with this container config: ``` \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\B13\Container\Tca\Registry::class)->configureContainer( (new \B13\Container\Tca\ContainerConfiguration( 'sp_container_2col', 'XXX 2-Spalten Container', 'Inhaltselemente in 2 gleichbreiten Spalten', [ [ ['name' => 'Spalte Links', 'colPos' => 200], ['name' => 'Spalte Rechts', 'colPos' => 201], ], ] )) ->setGroup('container') ); ``` Screenshots with patch: https://www.dropbox.com/scl/fi/jwozi80tiroaiafo3jp2s/Screenshot-2026-04-17-at-12.23.21.png?rlkey=6ilxnb7vg9whd2fxz9o51hrk0&dl=1 https://www.dropbox.com/scl/fi/qbtv1zgnbtlglelfxwdl0/Screenshot-2026-04-17-at-12.23.35.png?rlkey=xgr45lfstywe71ih2isuye1l9&dl=1 Screenshots without patch: https://www.dropbox.com/scl/fi/tmcdtl9y1xc7ghupsy0vt/Screenshot-2026-04-17-at-12.24.34.png?rlkey=m26rkpe2tmz3qvx7xc5rmw0hp&dl=1 https://www.dropbox.com/scl/fi/6ykt931a4c461nmvlh0oy/Screenshot-2026-04-17-at-12.24.42.png?rlkey=740jpu8s2fws7jwdevw6p74ug&dl=1 -
Georg Ringer voted on patch set 3 CR +2 V +2 04/17/26, 10:57
-
Georg Ringer merged patch set 4 04/17/26, 10:57