93329[TASK] Integrate wizard step configuration into tca schema
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/Wizard/PageWizardStepBuilder.php+27 −24
- typo3/sysext/backend/Tests/Functional/Wizard/PageWizardStepBuilderTest.php+0 −20
- typo3/sysext/core/Classes/Schema/Struct/WizardStep.phpnew+49 −0
- typo3/sysext/core/Classes/Schema/TcaSchema.php+8 −0
- typo3/sysext/core/Classes/Schema/TcaSchemaBuilder.php+35 −1
- typo3/sysext/core/Configuration/TCA/pages.php+2 −2
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109271-TCAConfigurationForDynamicWizardSteps.rst+9 −7
- typo3/sysext/core/Resources/Private/Language/wizard.xlf+3 −0
- typo3/sysext/core/Tests/Unit/Schema/TcaSchemaFactoryTest.php+175 −0
Review log 2638
Show 1013 earlier messages
-
Bastien Lutz uploaded patch set 1 03/24/26, 14:05
-
core-ci voted on patch set 1 V -1 03/24/26, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98596
-
Bastien Lutz uploaded patch set 2
V -103/24/26, 14:31 -
core-ci voted on patch set 2 V +1 03/24/26, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98601
-
Benjamin Franzke uploaded patch set 3
V +103/25/26, 07:10 -
Benjamin Franzke commented on patch set 3 03/25/26, 07:12
-
core-ci voted on patch set 3 V +1 03/25/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98652
-
Oli Bartsch commented on patch set 3 03/25/26, 09:50
Reviewing -
Oli Bartsch commented on patch set 3 03/25/26, 10:35
Thanks for the follow-up. The field validation is a nice improvement. However, this doesn't really address my original comment. `wizardSteps` is still read via `getRawConfiguration()['wizardSteps']`, just wrapped in a separate factory now. It's not processed during `TcaSchemaFactory::rebuild()`, not validated at TCA compilation time and not cached as part of the compiled schema. The factory builds objects ad-hoc per request from the same raw array. I also don't understand that `WizardStepSchema` implements `SchemaInterface` (with `__set_state()`) but isn't managed by any registry and is never serialized or cached. And the factory takes a schema as input rather than a table name. Can you please give me some reasoning behind this approach? Maybe I'm missing something, but my expectation was that wizardSteps would be integrated into the schema build process itself, so validation happens at compilation time and the result is cached.Reply
Done -
Bastien Lutz commented on patch set 3 03/25/26, 15:38
Reply
I think this is a naming missunderstanding. In the other comment you said this should be "a dedicated schema object". Therefor i was unsure wether to connect it with the existing TcaSchema object or not. I also thought about putting that in a capability but that felt wrong. That's why it is implemented that way right now. If i understand you correctly you would like to see that WizardStepSchema coupled directly to the TcaSchema? -
Oli Bartsch commented on patch set 3 03/25/26, 20:52
Reply
Yes exactly. "dedicated schema object" was maybe misleading, sorry. What I meant is that the wizard step configuration should become part of the TcaSchema itself, similar to how palettes or showitem are handled. Ideally processed and validated during `TcaSchemaFactory::rebuild()`, cached as part of the compiled schema, and accessible via something like `$tcaSchema->getSubSchema($doktype)->getWizardSteps()`. That way the validation happens once at build time, not on every request, and it follows the same lifecycle as all other TCA schema data. -
Bastien Lutz uploaded patch set 4
CR +1V +103/26/26, 10:21 -
Bastien Lutz commented on patch set 4 03/26/26, 10:21
Reply
Done
-
core-ci voted on patch set 4 V -1 03/26/26, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98759
-
Bastien Lutz uploaded patch set 5
V -103/26/26, 10:39 -
core-ci voted on patch set 5 V -1 03/26/26, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98760
-
Bastien Lutz uploaded patch set 6
V -103/26/26, 11:01 -
core-ci voted on patch set 6 V +1 03/26/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98767
-
Bastien Lutz rebased onto patch set 7
V +103/26/26, 14:36The following files contain Git conflicts: * typo3/sysext/backend/Classes/Wizard/PageWizardStepBuilder.php -
Bastien Lutz uploaded patch set 8 03/26/26, 14:48
-
Bastien Lutz marked it ready for review 03/26/26, 14:50
-
core-ci voted on patch set 8 V +1 03/26/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98790
-
core-ci voted on patch set 7 V -1 03/26/26, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98788
-
Benjamin Franzke voted on patch set 8 CR +1 V +1 03/26/26, 18:39
-
Benjamin Kott voted on patch set 8 CR +1 V +1 03/27/26, 08:27
-
Bastien Lutz rebased onto patch set 9
CR +1V +103/27/26, 14:58The following files contain Git conflicts: * typo3/sysext/backend/Classes/Wizard/PageWizardStepBuilder.php -
Bastien Lutz uploaded patch set 10 03/27/26, 15:05
-
Bastien Lutz marked it ready for review 03/27/26, 15:06
-
Benjamin Franzke voted on patch set 10 CR +1 V +1 03/27/26, 15:12
-
core-ci voted on patch set 10 V +1 03/27/26, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98890
-
core-ci voted on patch set 9 V -1 03/27/26, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98889
-
core-ci commented on patch set 10 03/27/26, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98890
-
Benjamin Franzke uploaded patch set 11
CR +1V +103/27/26, 20:22 -
Benjamin Franzke voted on patch set 11 CR +1 V +1 03/27/26, 20:22
-
core-ci voted on patch set 11 V +1 03/27/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98920
-
Benjamin Kott voted on patch set 11 CR +1 V +1 03/30/26, 07:01
-
Benjamin Franzke voted on patch set 11 CR +2 V +2 03/30/26, 07:42
-
Benjamin Franzke merged patch set 12 03/30/26, 07:42
WizardStepSchema.php:26