Review main Merged

93330[BUGFIX] Fix LinkBrowser usage in page creation wizard

Andreas Nedbal CR +2 V +2 Normal +85 −123 updated 03/25/26, 09:37

Commit message

Use events to send selected links from LinkBrowser to FormEngine.

Previously FormEngine, or rather the FormEngineLinkBrowserAdapter,
always assumed that FormEngine's opener window is the content frame
and the parent-detection logic followed that use case. With the
introduction of the Page Creation Wizard this is not correct anymore
and we need a new approach to send selected links to a form.

This change dispatches an event via the modal element that shows the
link browser, in order to act as intermediary between the form engine
field (wizard) and the link browser iframe.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1320

  1. Andreas Nedbal uploaded patch set 1 03/24/26, 14:14

  2. core-ci voted on patch set 1 V -1 03/24/26, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98598

  3. Benjamin Franzke uploaded patch set 2 V -1 03/24/26, 15:55

  4. Benjamin Franzke uploaded patch set 3 03/24/26, 15:57

  5. core-ci voted on patch set 3 V +1 03/24/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98614

  6. Benjamin Franzke uploaded patch set 4 V +1 03/24/26, 16:12

  7. core-ci voted on patch set 4 V +1 03/24/26, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98616

  8. core-ci voted on patch set 2 V -1 03/24/26, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98613

  9. Benjamin Franzke uploaded patch set 5 V +1 03/24/26, 16:33

  10. core-ci voted on patch set 5 V +1 03/24/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98618

  11. Benjamin Franzke rebased onto patch set 6 V +1 03/25/26, 08:15

  12. core-ci voted on patch set 6 V +1 03/25/26, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98659

  13. Andreas Nedbal voted on patch set 6 CR +1 V +1 03/25/26, 08:40

  14. Benjamin Franzke voted on patch set 6 CR -1 03/25/26, 09:19

  15. Benjamin Franzke uploaded patch set 7 CR +1 V +1 03/25/26, 09:20

  16. Benjamin Franzke voted on patch set 7 CR +1 V +1 03/25/26, 09:21

  17. Benjamin Kott voted on patch set 7 CR +1 V +1 03/25/26, 09:28

  18. core-ci voted on patch set 7 V +1 03/25/26, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98664

  19. Benjamin Franzke voted on patch set 7 CR +2 V +2 03/25/26, 09:37

  20. Benjamin Franzke merged patch set 8 03/25/26, 09:37