93332[!!!][BUGFIX] Move bodytext into its own palette
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/93332/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/93332/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benni Mack -2
- Christian Rath-Ulrich +1
-
Verified V -1 Blocked
- Christian Rath-Ulrich +1
- core-ci -1 CI
Merge conflicts 7
- main 91304[TASK] Move all LGL labels in core extension to dedicated file and unify syntax
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 95211[!!!] Removal of EXT:fluid_styled_content
- main 92249[!!!][TASK] Move content elements to EXT:fluid_styled_content
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 80074[WIP][!!!][TASK] Improve defaults for translating content
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/14.2/Important-108198-BodytextOfTextContentTypesIsAPalette.rstnew+41 −0
- typo3/sysext/core/Resources/Private/Language/Form/palettes.xlf+6 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+66 −0
- typo3/sysext/frontend/Configuration/TCA/Overrides/220-tt_content-content_type-textpic.php+1 −1
- typo3/sysext/frontend/Configuration/TCA/Overrides/230-tt_content-content_type-textmedia.php+1 −1
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+16 −1
- typo3/sysext/frontend/Tests/Functional/Configuration/ContentBodytextPaletteTest.phpnew+96 −0
Review log 913
-
Christian Jung uploaded patch set 1 03/24/26, 14:43
-
core-ci voted on patch set 1 V +1 03/24/26, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98603
-
Georg Ringer voted on patch set 1 CR +1 V +1 03/24/26, 16:38
-
Garvin Hicking commented on patch set 1 CR -1 03/25/26, 08:06
I understand the intention behind this, but changing it like this will affect code paths like: ``` ExtensionManagementUtility::addToAllTCATypes('myfield', 'tt_content', 'after:bodytext', 'myCType'); ``` which will then add fields in the palette and then affect every place than just `myCType`. There might be other side effects that this will have to ordering assignments. Since we are very close to the LTS release this is a change that could create friction and side-effects that are better placed in a `.0` release. And we would also need at least an "important.rst" file describing possible edge cases. As such I would vote to delay this for v15. The change itself is good and appreciated for accessibility reasons, thanks a lot for contributing! -
Christian Rath-Ulrich uploaded patch set 2
CR +1V +110/22/26, 15:26 -
Christian Rath-Ulrich commented on patch set 2 10/22/26, 15:28
Reply
Done -
Christian Rath-Ulrich uploaded patch set 3 10/22/26, 15:28
-
core-ci voted on patch set 2 V -1 10/22/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112130
-
core-ci voted on patch set 3 V -1 10/22/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112131
-
Garvin Hicking updated the commit message in patch set 4
V -110/22/26, 17:22 -
core-ci voted on patch set 4 V -1 10/22/26, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112159
-
Christian Rath-Ulrich voted on patch set 4 CR +1 V +1 10/23/26, 20:08
-
Benni Mack commented on patch set 4 CR -2 10/23/26, 21:26
I have to pause this unfortunately, as we probably need this in a bigger context change (extracting fluid styled content)