Review main Merged

93339[TASK] Update PHPStan to v2.1.43

Garvin Hicking CR +2 V +2 Easy +6 −18 updated 03/24/26, 23:39

Commit message

Updates PHPStan to the latest version 2.1.43.

New PHPStan version no longer reports two false
negatives.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.43
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Garvin Hicking uploaded patch set 1 03/24/26, 21:25

  2. core-ci voted on patch set 1 V +1 03/24/26, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98623

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 03/24/26, 21:38

  4. Simon Schaufelberger commented on patch set 1 CR +1 V +1 03/24/26, 21:56

    ready 4 merge!
  5. Oliver Klee voted on patch set 1 CR +1 V +1 03/24/26, 22:25

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 03/24/26, 23:39

  7. Christian Kuhn merged patch set 2 03/24/26, 23:39