Review main Merged

93345[BUGFIX] Fix framework packages for standalone testing framework

Helmut Hummel CR +2 V +2 Normal +111 −11 updated 03/25/26, 21:14

Commit message

The assumption made in #108345 that TYPO3 in classic mode
always delivers the full typo3/cms artifact turned out to be false.

The testing framework pulls in subtree splits, yet sets up
a TYPO3 classic testing environment. This causes the
PackageManager code to fail because it tries to load the
non-existing composer.json from the typo3/cms artifact.

Therefore, a new approach is chosen: during Composer build
time, the framework packages are extracted and written to a
file inside the typo3/cms-core package
(Resources/Private/Php/framework-packages.php).

This way, both regular classic mode installations and the
testing framework will work. The file is created during
composer install, so it is included in the package, and it
is also generated for the testing framework setup.

The file is generated only during composer install in
typo3/cms and is added to version control. Since its contents
change only when the composer.json replaces section changes,
for example when framework packages are added or removed,
there is no interference with regular checkouts. The file
will only change and need to be committed when required.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1931

Show 36 earlier messages
  1. Helmut Hummel uploaded patch set 1 03/25/26, 09:56

  2. core-ci voted on patch set 1 V -1 03/25/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98669

  3. Helmut Hummel uploaded patch set 2 V -1 03/25/26, 10:56

  4. core-ci voted on patch set 2 V -1 03/25/26, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98680

  5. Helmut Hummel uploaded patch set 3 V -1 03/25/26, 11:08

  6. core-ci voted on patch set 3 V -1 03/25/26, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98681

  1. Helmut Hummel uploaded patch set 4 V -1 03/25/26, 11:20

  2. Helmut Hummel uploaded patch set 5 03/25/26, 11:26

  3. core-ci voted on patch set 4 V -1 03/25/26, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98684

  4. core-ci voted on patch set 5 V -1 03/25/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98685

  5. core-ci commented on patch set 5 03/25/26, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98685

  6. core-ci commented on patch set 5 03/25/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98685

  7. core-ci commented on patch set 5 03/25/26, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98685

  8. Helmut Hummel uploaded patch set 6 V -1 03/25/26, 12:47

  9. Helmut Hummel uploaded patch set 7 03/25/26, 12:52

  10. core-ci voted on patch set 7 V +1 03/25/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98698

  11. Benni Mack commented on patch set 7 03/25/26, 13:49

    "into file" -> what does that mean?
  12. Helmut Hummel updated the commit message in patch set 8 V +1 03/25/26, 14:59

  13. Helmut Hummel commented on patch set 8 03/25/26, 15:00

    Reply

    Done
  14. core-ci voted on patch set 8 V +1 03/25/26, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98706

  15. Nikita Hovratov voted on patch set 8 V +1 03/25/26, 15:41

  16. Stefan Bürk commented on patch set 8 CR -1 03/25/26, 16:07

    -1 reviewing & testing things ....
  17. Helmut Hummel uploaded patch set 9 CR -1 V +1 03/25/26, 19:31

  18. core-ci voted on patch set 9 V -1 03/25/26, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98722

  19. Helmut Hummel uploaded patch set 10 V -1 03/25/26, 20:40

  20. core-ci voted on patch set 10 V +1 03/25/26, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98732

  21. Christian Kuhn voted on patch set 10 CR +1 V +1 03/25/26, 21:00

  22. Stefan Bürk voted on patch set 10 CR +1 V +1 03/25/26, 21:11

  23. Stefan Bürk commented on patch set 10 03/25/26, 21:12

    Reply

    Done
  24. Helmut Hummel voted on patch set 10 CR +2 V +2 03/25/26, 21:13

  25. Helmut Hummel merged patch set 11 03/25/26, 21:14