Review main Merged

93346[TASK] Merge form-engine page wizard data before submitting

Bastien Lutz CR +2 V +2 Normal +28 −25 updated 03/27/26, 14:12

Commit message

All fields from the different steps are merged before submitting.
This way server vs client side boundaries are better scoped and the
dataMap is built correctly and proper array access is possible.

To avoid that the uid placeholder differ when multiple form-engine
steps are used, a static placeholder is used for all dynamic
form-engine steps.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Bastien Lutz +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Bastien Lutz +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1420

  1. Bastien Lutz uploaded patch set 1 03/25/26, 10:43

  2. Bastien Lutz rebased onto patch set 2 03/25/26, 10:44

    The following files contain Git conflicts: * typo3/sysext/backend/Classes/Wizard/PageWizardProvider.php
  3. Bastien Lutz uploaded patch set 3 03/25/26, 10:46

  4. Bastien Lutz marked it ready for review 03/25/26, 10:46

  5. Andreas Nedbal voted on patch set 3 CR +1 V +1 03/25/26, 10:54

  6. core-ci voted on patch set 3 V +1 03/25/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98676

  7. core-ci voted on patch set 2 V -1 03/25/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98675

  8. Bastien Lutz uploaded patch set 4 03/25/26, 11:16

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  9. core-ci voted on patch set 1 V +1 03/25/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98674

  10. core-ci voted on patch set 4 V +1 03/25/26, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98683

  11. Benjamin Franzke uploaded patch set 5 CR +1 V +1 03/27/26, 12:50

  12. Benjamin Franzke uploaded patch set 6 CR +1 V +1 03/27/26, 12:51

  13. Benjamin Franzke updated the commit message in patch set 7 CR +1 V +1 03/27/26, 12:53

  14. core-ci voted on patch set 7 V -1 03/27/26, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98871

  15. Benjamin Franzke uploaded patch set 8 CR +1 V +1 03/27/26, 13:07

  16. core-ci voted on patch set 8 V +1 03/27/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98876

  17. Bastien Lutz voted on patch set 8 CR +1 V +1 03/27/26, 13:55

  18. Benjamin Kott voted on patch set 8 CR +1 V +1 03/27/26, 14:03

  19. Benjamin Franzke voted on patch set 8 CR +2 V +2 03/27/26, 14:12

  20. Benjamin Franzke merged patch set 9 03/27/26, 14:12