93347[FEATURE] Dynamic module access registry
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/backend/Classes/DependencyInjection/ModuleAccessGatePass.phpnew+83 −0
- typo3/sysext/backend/Classes/Module/AccessGate/AdminGate.phpnew+39 −0
- typo3/sysext/backend/Classes/Module/AccessGate/SystemMaintainerGate.phpnew+40 −0
- typo3/sysext/backend/Classes/Module/AccessGate/UserGate.phpnew+56 −0
- typo3/sysext/backend/Classes/Module/ModuleAccessGateInterface.phpnew+32 −0
- typo3/sysext/backend/Classes/Module/ModuleAccessGateRegistry.phpnew+67 −0
- typo3/sysext/backend/Classes/Module/ModuleAccessResult.phpnew+39 −0
- typo3/sysext/backend/Classes/Module/ModuleProvider.php+6 −33
- typo3/sysext/backend/Configuration/Services.php+8 −4
- typo3/sysext/backend/Tests/Functional/Module/ModuleProviderTest.php+23 −9
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/AdminGateTest.phpnew+68 −0
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/SystemMaintainerGateTest.phpnew+68 −0
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/UserGateTest.phpnew+81 −0
- typo3/sysext/backend/Tests/Unit/Module/ModuleAccessGateRegistryTest.phpnew+67 −0
- typo3/sysext/core/Classes/Attribute/AsModuleAccessGate.phpnew+38 −0
- typo3/sysext/core/Configuration/Services.php+12 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109365-IntroduceModuleAccessGatesForBackendModules.rstnew+104 −0
Review log 1419
-
Benni Mack uploaded patch set 1 03/25/26, 12:11
-
core-ci voted on patch set 1 V -1 03/25/26, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98687
-
Benni Mack uploaded patch set 2
V -103/25/26, 12:50 -
core-ci voted on patch set 2 V +1 03/25/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98696
-
Benni Mack updated the commit message in patch set 3
V +103/25/26, 14:38 -
core-ci voted on patch set 3 V +1 03/25/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98704
-
Garvin Hicking commented on patch set 3 03/25/26, 19:25
Could we align this with https://review.typo3.org/c/Packages/TYPO3.CMS/+/91172 - even though extbase of course is different, it might be weird to handle multiple kinds of attributes when they all deal with authorization? -
Benni Mack marked it ready for review 03/25/26, 20:44
-
Benni Mack marked it work in progress 03/25/26, 20:44
-
Benni Mack marked it ready for review 03/26/26, 14:30
-
Benni Mack commented on patch set 4
V +103/26/26, 14:59Published edit on patch set 3. -
Benni Mack commented on patch set 4 03/26/26, 15:01
Reply
these are different use-cases... "Authorize" is for frontend use-case -
core-ci voted on patch set 4 V +1 03/26/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98792
-
Benni Mack uploaded patch set 5
V +103/26/26, 15:25 -
Simon Schaufelberger commented on patch set 5 CR +1 V +1 03/26/26, 16:01
love this feature! -
core-ci voted on patch set 5 V +1 03/26/26, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98795
-
Garvin Hicking commented on patch set 5 CR +1 V +1 03/27/26, 07:47
Reply
Acknowledged. I was thinking more in terms of terminology. But I see now after review that the 'access' is already kind of set in stone. So all good. -
Benni Mack voted on patch set 5 CR +2 V +2 03/27/26, 08:14
-
Benni Mack merged patch set 6 03/27/26, 08:14