Review main Merged

93347[FEATURE] Dynamic module access registry

Benni Mack CR +2 V +2 Hard +831 −46 updated 03/27/26, 08:14

Commit message

The keywords "user", "admin" and "systemMaintainer"
in the module registration are now moved into ModuleGates,
making the access check more configurable and extendable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 1419

  1. Benni Mack uploaded patch set 1 03/25/26, 12:11

  2. core-ci voted on patch set 1 V -1 03/25/26, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98687

  3. Benni Mack uploaded patch set 2 V -1 03/25/26, 12:50

  4. core-ci voted on patch set 2 V +1 03/25/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98696

  5. Benni Mack updated the commit message in patch set 3 V +1 03/25/26, 14:38

  6. core-ci voted on patch set 3 V +1 03/25/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98704

  7. Garvin Hicking commented on patch set 3 03/25/26, 19:25

    Could we align this with https://review.typo3.org/c/Packages/TYPO3.CMS/+/91172 - even though extbase of course is different, it might be weird to handle multiple kinds of attributes when they all deal with authorization?
  8. Benni Mack marked it ready for review 03/25/26, 20:44

  9. Benni Mack marked it work in progress 03/25/26, 20:44

  10. Benni Mack marked it ready for review 03/26/26, 14:30

  11. Benni Mack commented on patch set 4 V +1 03/26/26, 14:59

    Published edit on patch set 3.
  12. Benni Mack commented on patch set 4 03/26/26, 15:01

    Reply

    these are different use-cases... "Authorize" is for frontend use-case
  13. core-ci voted on patch set 4 V +1 03/26/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98792

  14. Benni Mack uploaded patch set 5 V +1 03/26/26, 15:25

  15. Simon Schaufelberger commented on patch set 5 CR +1 V +1 03/26/26, 16:01

    love this feature!
  16. core-ci voted on patch set 5 V +1 03/26/26, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98795

  17. Garvin Hicking commented on patch set 5 CR +1 V +1 03/27/26, 07:47

    Reply

    Acknowledged. I was thinking more in terms of terminology. But I see now after review that the 'access' is already kind of set in stone. So all good.
  18. Benni Mack voted on patch set 5 CR +2 V +2 03/27/26, 08:14

  19. Benni Mack merged patch set 6 03/27/26, 08:14