Review main Merged

93351[FEATURE] Hide FormEngine fields with no selectable items

Oli Bartsch CR +2 V +2 Expert +1194 −43 updated 03/30/26, 09:11

Commit message

Relational fields (type=select with foreign_table, type=category)
are now automatically removed from the form when no selectable items
are available. Language fields (type=language) are hidden when only
a single language is configured.

This improves the editing experience by not showing empty select
fields, category trees, or single-choice language dropdowns that
serve no purpose.

For admins with debug output enabled, the fields are still
displayed as readonly with an information badge.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2634

Show 79 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/25/26, 16:02

  2. Oli Bartsch uploaded patch set 2 03/25/26, 16:28

  3. Oli Bartsch wrote 03/27/26, 17:21

    Unset private
  4. Oli Bartsch rebased onto patch set 3 03/27/26, 17:21

  5. core-ci voted on patch set 3 V -1 03/27/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98906

  6. Garvin Hicking commented on patch set 3 03/27/26, 17:56

    Feature-109366-HideFormFieldsWithNoSelectableItems.rst:62

    ```suggestion `hideIfNoItems` to `false` in their TCA configuration. ```
  7. Oli Bartsch uploaded patch set 4 V -1 03/27/26, 18:28

  8. core-ci voted on patch set 4 V -1 03/27/26, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98908

  9. Oli Bartsch uploaded patch set 5 V -1 03/27/26, 19:00

  1. Oli Bartsch commented on patch set 5 03/27/26, 19:01

    Feature-109366-HideFormFieldsWithNoSelectableItems.rst:62 Reply

    Done
  2. core-ci voted on patch set 5 V +1 03/27/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98912

  3. Georg Ringer commented on patch set 5 03/28/26, 06:53

    while I have always been a big fan of that I don't know if this leads into issues because also admins don't find a field anymore. Example could be registerPageTSConfigFile usage or if sys_categories are not filled because of a additonal_where constraint, whatever. I suggest: Hide the field for editors, for admins gray it out or add a small infobox instead of completly removing it. what do you say?

    Feature-109366-HideFormFieldsWithNoSelectableItems.rst:50

    I am not a fan of double negations. why not showIfEmpt = true?
  4. Oli Bartsch uploaded patch set 6 V +1 03/29/26, 16:45

  5. Oli Bartsch commented on patch set 6 03/29/26, 16:45

    Feature-109366-HideFormFieldsWithNoSelectableItems.rst:50 Reply

    Done
  6. core-ci voted on patch set 6 V +1 03/29/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98989

  7. Georg Ringer voted on patch set 6 CR +1 V +1 03/29/26, 17:08

  8. Garvin Hicking commented on patch set 6 03/29/26, 17:12

    NoSelectableItemsAvailable.php:33

    use new translation domain syntax with translate() and key+domain?
  9. Josef Glatz updated the commit message in patch set 7 CR +1 V +1 03/30/26, 05:05

  10. Josef Glatz voted on patch set 7 V +1 03/30/26, 05:05

  11. core-ci voted on patch set 7 V +1 03/30/26, 05:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99005

  12. Josef Glatz voted on patch set 7 CR +1 03/30/26, 05:30

  13. Josua Vogel commented on patch set 7 03/30/26, 06:31

    the feature rst must be moved to the 14.2 folder
  14. Josef Glatz uploaded patch set 8 CR +1 V +1 03/30/26, 07:06

  15. Josef Glatz commented on patch set 8 CR +1 V +1 03/30/26, 07:06

    Reply

    Done
  16. Josef Glatz uploaded patch set 9 CR +1 V +1 03/30/26, 07:14

  17. Josef Glatz commented on patch set 9 CR +1 V +1 03/30/26, 07:14

    NoSelectableItemsAvailable.php:33 Reply

    Done
  18. core-ci voted on patch set 8 V +1 03/30/26, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99007

  19. Josef Glatz commented on patch set 10 CR +1 V +1 03/30/26, 07:18

    Published edit on patch set 9.
  20. Josef Glatz voted on patch set 10 CR +1 V +1 03/30/26, 07:18

  21. core-ci voted on patch set 10 V +1 03/30/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99011

  22. core-ci voted on patch set 9 V +1 03/30/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99010

  23. Garvin Hicking commented on patch set 10 CR +1 03/30/26, 08:54

    (could not test in depth, but think we can take this in)
  24. Georg Ringer voted on patch set 10 CR +2 V +2 03/30/26, 09:11

  25. Georg Ringer merged patch set 11 03/30/26, 09:11