93351[FEATURE] Hide FormEngine fields with no selectable items
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Josef Glatz +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/Form/FieldInformation/NoSelectableItemsAvailable.php2new+43 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCategory.php+21 −17
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsRemoveEmptyRelations.phpnew+138 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+22 −9
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+41 −16
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaColumnsRemoveEmptyRelationsTest.phpnew+244 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsRemoveEmptyRelationsTest.phpnew+601 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+9 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109366-HideFormFieldsWithNoSelectableItems.rstnew+71 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 2634
Show 79 earlier messages
-
Oli Bartsch uploaded patch set 1 03/25/26, 16:02
-
Oli Bartsch uploaded patch set 2 03/25/26, 16:28
-
Oli Bartsch wrote 03/27/26, 17:21
Unset private -
Oli Bartsch rebased onto patch set 3 03/27/26, 17:21
-
core-ci voted on patch set 3 V -1 03/27/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98906
-
Garvin Hicking commented on patch set 3 03/27/26, 17:56
Feature-109366-HideFormFieldsWithNoSelectableItems.rst:62```suggestion `hideIfNoItems` to `false` in their TCA configuration. ``` -
Oli Bartsch uploaded patch set 4
V -103/27/26, 18:28 -
core-ci voted on patch set 4 V -1 03/27/26, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98908
-
Oli Bartsch uploaded patch set 5
V -103/27/26, 19:00
-
Oli Bartsch commented on patch set 5 03/27/26, 19:01
Feature-109366-HideFormFieldsWithNoSelectableItems.rst:62ReplyDone -
core-ci voted on patch set 5 V +1 03/27/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98912
-
Georg Ringer commented on patch set 5 03/28/26, 06:53
while I have always been a big fan of that I don't know if this leads into issues because also admins don't find a field anymore. Example could be registerPageTSConfigFile usage or if sys_categories are not filled because of a additonal_where constraint, whatever. I suggest: Hide the field for editors, for admins gray it out or add a small infobox instead of completly removing it. what do you say?Feature-109366-HideFormFieldsWithNoSelectableItems.rst:50I am not a fan of double negations. why not showIfEmpt = true? -
Oli Bartsch uploaded patch set 6
V +103/29/26, 16:45 -
Oli Bartsch commented on patch set 6 03/29/26, 16:45
Feature-109366-HideFormFieldsWithNoSelectableItems.rst:50ReplyDone -
core-ci voted on patch set 6 V +1 03/29/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98989
-
Georg Ringer voted on patch set 6 CR +1 V +1 03/29/26, 17:08
-
Garvin Hicking commented on patch set 6 03/29/26, 17:12
NoSelectableItemsAvailable.php:33use new translation domain syntax with translate() and key+domain? -
Josef Glatz updated the commit message in patch set 7
CR +1V +103/30/26, 05:05 -
Josef Glatz voted on patch set 7 V +1 03/30/26, 05:05
-
core-ci voted on patch set 7 V +1 03/30/26, 05:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99005
-
Josef Glatz voted on patch set 7 CR +1 03/30/26, 05:30
-
Josua Vogel commented on patch set 7 03/30/26, 06:31
the feature rst must be moved to the 14.2 folder -
Josef Glatz uploaded patch set 8
CR +1V +103/30/26, 07:06 -
Josef Glatz commented on patch set 8 CR +1 V +1 03/30/26, 07:06
Reply
Done -
Josef Glatz uploaded patch set 9
CR +1V +103/30/26, 07:14 -
Josef Glatz commented on patch set 9 CR +1 V +1 03/30/26, 07:14
NoSelectableItemsAvailable.php:33ReplyDone -
core-ci voted on patch set 8 V +1 03/30/26, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99007
-
Josef Glatz commented on patch set 10
CR +1V +103/30/26, 07:18Published edit on patch set 9. -
Josef Glatz voted on patch set 10 CR +1 V +1 03/30/26, 07:18
-
core-ci voted on patch set 10 V +1 03/30/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99011
-
core-ci voted on patch set 9 V +1 03/30/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99010
-
Garvin Hicking commented on patch set 10 CR +1 03/30/26, 08:54
(could not test in depth, but think we can take this in) -
Georg Ringer voted on patch set 10 CR +2 V +2 03/30/26, 09:11
-
Georg Ringer merged patch set 11 03/30/26, 09:11