Review main Merged

93354[FEATURE] Allow queryParams as array for typolink

Benni Mack CR +2 V +2 Normal +179 −32 updated 03/26/26, 22:15

Commit message

When using the typolink / PageLinkBuilder functionality,
additional query parameters were added via "additionalParams".

This is due to historical reasons, as typolink was used
as string / stdWrap. Nowadays, people want to write
PHP-based link logic, and add additional query params,
which is now handled via a new property in the PageLinkBuilder
/ LinkFactory API "queryParameters".

This way, developers do not convert their additional
query parameters to string for "additionalParams"
but can use their PHP Array directly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 913

  1. Benni Mack uploaded patch set 1 03/25/26, 19:26

  2. core-ci voted on patch set 1 V +1 03/25/26, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98721

  3. Benni Mack uploaded patch set 2 V +1 03/25/26, 20:12

  4. core-ci voted on patch set 2 V -1 03/25/26, 20:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98726

  5. Benni Mack uploaded patch set 3 V -1 03/25/26, 20:31

  6. Benni Mack marked it ready for review 03/25/26, 20:31

  7. Benni Mack uploaded patch set 4 03/25/26, 20:33

  8. core-ci voted on patch set 3 V -1 03/25/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98728

  9. core-ci voted on patch set 4 V +1 03/25/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98729

  10. Simon Schaufelberger commented on patch set 4 CR +1 V +1 03/26/26, 16:04

    thank you!
  11. Garvin Hicking commented on patch set 4 CR +1 V +1 03/26/26, 20:08

    PageLinkBuilder.php:341 Unresolved

    ```suggestion if ($conf['queryParameters'] !== []) { ``` Would read clearer and avoid empty() magic - but dont care too much if you apply this. The outer array cast of the argument ensures its arrayness...?
  12. Georg Ringer voted on patch set 4 CR +2 V +2 03/26/26, 22:15

  13. Georg Ringer merged patch set 5 03/26/26, 22:15