93354[FEATURE] Allow queryParams as array for typolink
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-109370-ArrayBasedQueryParametersForTypolink.rstnew+56 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+4 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+1 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php1+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+39 −0
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.php+65 −0
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+7 −19
Review log 913
-
Benni Mack uploaded patch set 1 03/25/26, 19:26
-
core-ci voted on patch set 1 V +1 03/25/26, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98721
-
Benni Mack uploaded patch set 2
V +103/25/26, 20:12 -
core-ci voted on patch set 2 V -1 03/25/26, 20:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98726
-
Benni Mack uploaded patch set 3
V -103/25/26, 20:31 -
Benni Mack marked it ready for review 03/25/26, 20:31
-
Benni Mack uploaded patch set 4 03/25/26, 20:33
-
core-ci voted on patch set 3 V -1 03/25/26, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98728
-
core-ci voted on patch set 4 V +1 03/25/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98729
-
Simon Schaufelberger commented on patch set 4 CR +1 V +1 03/26/26, 16:04
thank you! -
Garvin Hicking commented on patch set 4 CR +1 V +1 03/26/26, 20:08
PageLinkBuilder.php:341Unresolved```suggestion if ($conf['queryParameters'] !== []) { ``` Would read clearer and avoid empty() magic - but dont care too much if you apply this. The outer array cast of the argument ensures its arrayness...? -
Georg Ringer voted on patch set 4 CR +2 V +2 03/26/26, 22:15
-
Georg Ringer merged patch set 5 03/26/26, 22:15