Review main Merged

93355[BUGFIX] Prevent file list crash without EXT:filemetadata

Robert Hafenried CR +2 V +2 Easy +11 −1 updated 03/29/26, 09:17

Commit message

When EXT:filemetadata is not enabled, but display fields
are configured in the file listing (for example via UserTS
or in the "uc" user settings), the label resolving
of these fields will fail and cause a TypeError.

This patch ensures that only fields can be passed
which are available via TCA Schema API.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Robert Hafenried uploaded patch set 1 03/25/26, 19:33

  2. core-ci voted on patch set 1 V -1 03/25/26, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98723

  3. Robert Hafenried uploaded patch set 2 V -1 03/25/26, 21:28

  4. core-ci voted on patch set 2 V -1 03/25/26, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98737

  5. Garvin Hicking uploaded patch set 3 V -1 03/27/26, 10:41

  6. core-ci voted on patch set 3 V +1 03/27/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98855

  7. Simon Schaufelberger voted on patch set 3 CR +1 V +1 03/27/26, 12:12

  8. Garvin Hicking commented on patch set 4 CR +1 V +1 03/27/26, 13:29

    Published edit on patch set 3.
  9. Garvin Hicking voted on patch set 4 CR +1 V +1 03/27/26, 13:29

  10. core-ci voted on patch set 4 V +1 03/27/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98881

  11. Guido Schmechel voted on patch set 4 CR +1 03/28/26, 18:32

  12. Georg Ringer voted on patch set 4 CR +2 V +2 03/29/26, 09:17

  13. Georg Ringer merged patch set 5 03/29/26, 09:17