Review main Merged

93362[BUGFIX] Fix stale values in page creation wizard confirmation step

Tobias Wojtylak CR +2 V +2 Normal +39 −71 updated 03/27/26, 09:53

Commit message

The confirmation step of the page creation wizard did not
reflect updated field values when a user edited fields (e.g. title)
after the initial input. Instead, stale values from the initial state
were displayed.

This change ensures that the summary view is properly refreshed and
uses the current form state when returning to the confirmation step,
it uses the asynchronous beforeAdvance() hook to ensure that
summary data is always loaded before trying to render the synchronous
summary step.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1419

  1. Tobias Wojtylak uploaded patch set 1 03/26/26, 09:00

  2. core-ci voted on patch set 1 V +1 03/26/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98756

  3. Tobias Wojtylak marked it ready for review 03/26/26, 09:23

  4. Benjamin Franzke rebased onto patch set 2 V +1 03/26/26, 12:33

  5. core-ci voted on patch set 2 V +1 03/26/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98775

  6. Benjamin Franzke commented on patch set 2 V 0 CR -1 03/26/26, 13:27

    on it
  7. Benjamin Franzke uploaded patch set 3 CR -1 V +1 03/26/26, 14:09

  8. Benjamin Franzke commented on patch set 3 CR +1 V +1 03/26/26, 14:09

    Reply

    Done
  9. core-ci voted on patch set 3 V -1 03/26/26, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98784

  10. Tobias Wojtylak commented on patch set 3 03/26/26, 14:34

    @ben@bnf.dev Previously, the data was only fetched when it was actually needed for display (in the summary). Now it’s requested when clicking “Next”. I consider the former approach more performant. Also, beforeAdvance doesn’t seem to use await so data may be not available
  11. Benjamin Franzke commented on patch set 3 03/26/26, 14:57

    Reply

    `beforeAdvance` is awaited here https://github.com/TYPO3/typo3/blob/9c40a1418b3cfa008ed3ad3cc738150c169b04f2/Build/Sources/TypeScript/backend/wizard/wizard.ts#L292-L294 Or do you refer to another case? My problem with the previous implementation was that the synchronous step renders a TemplateResult (that needed to update) and the fetch (`run()` was triggered only when the summary is triggered. That means the user would not see immediate feedback, but theoretcially a spinner after loading the summary step. I thought about allowing `getSummaryData` to be async, which would probably the best approach, but felt like too much work for now. What do you think?
  12. core-ci commented on patch set 3 03/26/26, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98784

  13. Tobias Wojtylak commented on patch set 3 03/26/26, 15:52

    Reply

    Regarding `beforeAdvance`: You're right. I must have slipped a line there. Sorry about that. Regarding the spinner: I think it's okay if it’s visible briefly. The requests should complete quickly. Regarding `getSummaryData` async: Yes, that could be an idea.
  14. Benjamin Franzke uploaded patch set 4 CR +1 V +1 03/27/26, 07:37

  15. core-ci voted on patch set 4 V +1 03/27/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98836

  16. Benjamin Kott voted on patch set 4 CR +1 V +1 03/27/26, 09:52

  17. Benjamin Franzke commented on patch set 4 CR +1 V +1 03/27/26, 09:52

    Reply

    Let's go with this solution, as this makes this code working while reducing complexity. We can iterate on this later if needed.
  18. Benjamin Franzke voted on patch set 4 CR +2 V +2 03/27/26, 09:53

  19. Benjamin Franzke merged patch set 5 03/27/26, 09:53