93362[BUGFIX] Fix stale values in page creation wizard confirmation step
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/page-wizard/steps/form-engine-step.ts+26 −38
- Build/tests/playwright/e2e/recycler/recycler-module.spec.ts+1 −1
- Build/tests/playwright/e2e/workspaces/workspaces-module.spec.ts+1 −1
- Build/tests/playwright/fixtures/page-wizard.ts+10 −30
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/steps/form-engine-step.js+1 −1
Review log 1419
-
Tobias Wojtylak uploaded patch set 1 03/26/26, 09:00
-
core-ci voted on patch set 1 V +1 03/26/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98756
-
Tobias Wojtylak marked it ready for review 03/26/26, 09:23
-
Benjamin Franzke rebased onto patch set 2
V +103/26/26, 12:33 -
core-ci voted on patch set 2 V +1 03/26/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98775
-
Benjamin Franzke commented on patch set 2 V 0 CR -1 03/26/26, 13:27
on it -
Benjamin Franzke uploaded patch set 3
CR -1V +103/26/26, 14:09 -
Benjamin Franzke commented on patch set 3 CR +1 V +1 03/26/26, 14:09
Reply
Done -
core-ci voted on patch set 3 V -1 03/26/26, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98784
-
Tobias Wojtylak commented on patch set 3 03/26/26, 14:34
@ben@bnf.dev Previously, the data was only fetched when it was actually needed for display (in the summary). Now it’s requested when clicking “Next”. I consider the former approach more performant. Also, beforeAdvance doesn’t seem to use await so data may be not available -
Benjamin Franzke commented on patch set 3 03/26/26, 14:57
Reply
`beforeAdvance` is awaited here https://github.com/TYPO3/typo3/blob/9c40a1418b3cfa008ed3ad3cc738150c169b04f2/Build/Sources/TypeScript/backend/wizard/wizard.ts#L292-L294 Or do you refer to another case? My problem with the previous implementation was that the synchronous step renders a TemplateResult (that needed to update) and the fetch (`run()` was triggered only when the summary is triggered. That means the user would not see immediate feedback, but theoretcially a spinner after loading the summary step. I thought about allowing `getSummaryData` to be async, which would probably the best approach, but felt like too much work for now. What do you think? -
core-ci commented on patch set 3 03/26/26, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98784
-
Tobias Wojtylak commented on patch set 3 03/26/26, 15:52
Reply
Regarding `beforeAdvance`: You're right. I must have slipped a line there. Sorry about that. Regarding the spinner: I think it's okay if it’s visible briefly. The requests should complete quickly. Regarding `getSummaryData` async: Yes, that could be an idea. -
Benjamin Franzke uploaded patch set 4
CR +1V +103/27/26, 07:37 -
core-ci voted on patch set 4 V +1 03/27/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98836
-
Benjamin Kott voted on patch set 4 CR +1 V +1 03/27/26, 09:52
-
Benjamin Franzke commented on patch set 4 CR +1 V +1 03/27/26, 09:52
Reply
Let's go with this solution, as this makes this code working while reducing complexity. We can iterate on this later if needed. -
Benjamin Franzke voted on patch set 4 CR +2 V +2 03/27/26, 09:53
-
Benjamin Franzke merged patch set 5 03/27/26, 09:53