93364[TASK] Allow bulk creation of page doktypes that require title only
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+12 −0
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+30 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_pages_new.xlf+18 −0
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.fluid.html+120 −79
Review log 1215
-
Benjamin Franzke uploaded patch set 1 03/26/26, 09:48
-
core-ci voted on patch set 1 V +1 03/26/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98758
-
Benjamin Franzke uploaded patch set 2
V +103/30/26, 11:29 -
core-ci voted on patch set 2 V +1 03/30/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99052
-
Georg Ringer commented on patch set 2 03/30/26, 13:00
works but IMHO the goal of the page wizard was to avoid incomplete pages, now it is possible to create shortcut pages again. don't know if that is good or bad -
Benjamin Franzke commented on patch set 2 03/30/26, 13:41
Reply
yes, shortcut pages are still "open". Several good attempts were tried, but none could find consensus yet. The current one is the following: > 93021: [TASK] Mark shortcut as required if shortcut_mode=0 | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93021 Whatever lands there, will be integrated here as well, which means "shortcuts" will be filtered then. (right now incomplete shortcut pages can be created via the creation wizard, which is why this patch allows for the same feature set) -
Garvin Hicking commented on patch set 2 V -1 03/30/26, 13:43
I get this error when trying to create a page in the newly created "Camino" pagetree: ``` (1/1) TypeError TYPO3\CMS\Core\Schema\TcaSchema::getSubSchema(): Argument #1 ($subSchema) must be of type string, int given, called in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php on line 195 in /var/www/html/typo3-core/typo3/sysext/core/Classes/Schema/TcaSchema.php line 238 at TYPO3\CMS\Core\Schema\TcaSchema -> getSubSchema (501 ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php line 195 at TYPO3\CMS\Backend\Controller\Page\NewMultiplePagesController -> filterTypesThatOnlyRequireTitle (array('Page' => array(array('label' => 'Standard Page', 'value' => '1', 'icon' => 'apps-pagetree-page-default', 'iconOverlay' => null, 'group' => 'default', 'description' => null), array('label' => 'Backend User Section', 'value' => '6', 'icon' => 'apps-pagetree-page-backend-users', 'iconOverlay' => null, 'group' => 'default', 'description' => null)), 'Link' => array(array('label' => 'Shortcut', 'value' => '4', 'icon' => 'apps-pagetree-page-shortcut', 'iconOverlay' => null, 'group' => 'link', 'description' => null)), 'Special' => array(array('label' => 'Folder', 'value' => '254', 'icon' => 'apps-pagetree-folder-default', 'iconOverlay' => null, 'group' => 'special', 'description' => null), array('label' => 'Newsletter', 'value' => 501, 'icon' => 'ppw-cr-newsletter', 'iconOverlay' => null, 'group' => 'special', 'description' => null))), array('Link') ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php line 122 at TYPO3\CMS\Backend\Controller\Page\NewMultiplePagesController -> mainAction (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Http/RouteDispatcher.php line 84 at TYPO3\CMS\Backend\Http\RouteDispatcher -> dispatch (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Http/RequestHandler.php line 85 at TYPO3\CMS\Backend\Http\RequestHandler -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/ResponsePropagation.php line 34 at TYPO3\CMS\Core\Middleware\ResponsePropagation -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(TYPO3\CMS\Backend\Http\RequestHandler) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/AdditionalResponseHeaders.php line 37 at TYPO3\CMS\Backend\Middleware\AdditionalResponseHeaders -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/PageContextInitialization.php line 66 at TYPO3\CMS\Backend\Middleware\PageContextInitialization -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/SiteResolver.php line 64 at TYPO3\CMS\Backend\Middleware\SiteResolver -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/SudoModeInterceptor.php line 62 at TYPO3\CMS\Backend\Middleware\SudoModeInterceptor -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/JavaScriptLabelImportMapEntryResolver.php line 53 at TYPO3\CMS\Backend\Middleware\JavaScriptLabelImportMapEntryResolver -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyHeaders.php line 58 at TYPO3\CMS\Backend\Middleware\ContentSecurityPolicyHeaders -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/BackendModuleValidator.php line 85 at TYPO3\CMS\Backend\Middleware\BackendModuleValidator -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php line 171 at TYPO3\CMS\Backend\Middleware\BackendUserAuthenticator -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/reactions/Classes/Http/Middleware/ReactionResolver.php line 56 at TYPO3\CMS\Reactions\Http\Middleware\ReactionResolver -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/RequestTokenMiddleware.php line 71 at TYPO3\CMS\Core\Middleware\RequestTokenMiddleware -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/BackendRouteInitialization.php line 78 at TYPO3\CMS\Backend\Middleware\BackendRouteInitialization -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/ContentSecurityPolicyReporter.php line 45 at TYPO3\CMS\Backend\Middleware\ContentSecurityPolicyReporter -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/ForcedHttpsBackendRedirector.php line 55 at TYPO3\CMS\Backend\Middleware\ForcedHttpsBackendRedirector -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Middleware/LockedBackendGuard.php line 76 at TYPO3\CMS\Backend\Middleware\LockedBackendGuard -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/NormalizedParamsAttribute.php line 44 at TYPO3\CMS\Core\Middleware\NormalizedParamsAttribute -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 70 at TYPO3\CMS\Core\Http\MiddlewareDispatcher -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/AbstractApplication.php line 83 at TYPO3\CMS\Core\Http\AbstractApplication -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/backend/Classes/Http/Application.php line 56 at TYPO3\CMS\Backend\Http\Application -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/RequestHandler.php line 38 at TYPO3\CMS\Core\Http\RequestHandler -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/ResponsePropagation.php line 34 at TYPO3\CMS\Core\Middleware\ResponsePropagation -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(TYPO3\CMS\Core\Http\RequestHandler) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/NormalizedParamsAttribute.php line 44 at TYPO3\CMS\Core\Middleware\NormalizedParamsAttribute -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Middleware/VerifyHostHeader.php line 55 at TYPO3\CMS\Core\Middleware\VerifyHostHeader -> process (object(TYPO3\CMS\Core\Http\ServerRequest), object(Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 162 at Psr\Http\Server\RequestHandlerInterface@anonymous/var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php:128$20c -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/MiddlewareDispatcher.php line 70 at TYPO3\CMS\Core\Http\MiddlewareDispatcher -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/AbstractApplication.php line 83 at TYPO3\CMS\Core\Http\AbstractApplication -> handle (object(TYPO3\CMS\Core\Http\ServerRequest) ) in /var/www/html/typo3-core/typo3/sysext/core/Classes/Http/AbstractApplication.php line 106 at TYPO3\CMS\Core\Http\AbstractApplication -> run ( ) in /var/www/html/public/index.php line 28 at {closure} ( ) in /var/www/html/public/index.php line 33 ``` -
Garvin Hicking commented on patch set 2 03/30/26, 13:45
Using this: ``` $schema = $pageSchema->getSubSchema((string) $typeValue); ``` works for me; probably I'm using legacy doktypes somewhere (bootstrap package?) -
Garvin Hicking commented on patch set 2 03/30/26, 13:48
Reply
This is because I have an extension doing: ``` $dokTypeRegistry = GeneralUtility::makeInstance(PageDoktypeRegistry::class); $dokTypeRegistry->add( 501, // Newsletter [ 'allowedTables' => '*', ], ); ``` which is using the deprecated functionality, but this still needs to work for the deprecation phase. -
Benjamin Franzke uploaded patch set 3
V +103/30/26, 14:09 -
Benjamin Franzke commented on patch set 3 03/30/26, 14:09
Reply
Thanks a lot! Fixed.Reply
Ack, that's a good solution. Applied. -
core-ci voted on patch set 3 V +1 03/30/26, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99072
-
Garvin Hicking voted on patch set 3 CR +1 V +1 03/30/26, 15:03
-
Georg Ringer voted on patch set 3 CR +2 V +2 03/30/26, 15:38
-
Georg Ringer merged patch set 4 03/30/26, 15:38