Review main Abandoned

93365[FEATURE] Add Toggle for dark / light mode (WIP)

David Bruchmann CR 0 V -1 Hard +302 −0 updated 04/20/26, 16:30

Commit message

* add domain-settings for selection of toggle-type
* add toggles (WIP)
* add JavaScript
* add CSS (WIP)
* add icons

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 15

Review log 812

  1. David Bruchmann uploaded patch set 1 03/26/26, 11:26

  2. David Bruchmann marked it work in progress 03/26/26, 11:27

  3. core-ci voted on patch set 1 V -1 03/26/26, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98769

  4. Garvin Hicking commented on patch set 1 03/28/26, 17:43

    Unresolved

    ```suggestion Releases: main ``` Only use main.
  5. Garvin Hicking commented on patch set 1 03/28/26, 17:46

    settings.definitions.yaml:19 Unresolved

    You can drop descriptions with a label, its automatically loaded from labels.xlf like the other options, if you name the key right
  6. David Bruchmann rebased onto patch set 2 V -1 03/31/26, 06:24

  7. David Bruchmann rebased onto patch set 3 03/31/26, 06:28

  8. core-ci voted on patch set 2 V -1 03/31/26, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99216

  9. core-ci voted on patch set 3 V -1 03/31/26, 07:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99219

  10. David Bruchmann rebased onto patch set 4 V -1 04/20/26, 08:35

  11. core-ci voted on patch set 4 V -1 04/20/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100522

  12. Garvin Hicking abandoned the change 04/20/26, 16:30

    Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/93477 - please merge in there