Review main Abandoned

93366[TASK] Improve error handling and generalize Localization Wizard

Tobias Wojtylak CR 0 V 0 Hard +377 −622 updated 09/04/26, 06:10

Commit message

PageWizard/Localization Wizard now returns HTTP 400 on failed
operations. SubmissionResult was split into SubmissionErrorResult
and SubmissionSuccessResult. The Localization Wizard now uses
generic Wizard SubmissionResult and Finisher classes.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 31

Show 11 more files

Review log 1319

  1. Tobias Wojtylak uploaded patch set 1 03/26/26, 12:11

  2. core-ci voted on patch set 1 V -1 03/26/26, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98772

  3. Tobias Wojtylak uploaded patch set 2 V -1 03/26/26, 13:09

  4. core-ci voted on patch set 2 V -1 03/26/26, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98780

  5. Tobias Wojtylak uploaded patch set 3 V -1 03/26/26, 13:46

  6. core-ci voted on patch set 3 V +1 03/26/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98783

  7. Tobias Wojtylak marked it ready for review 03/26/26, 15:38

  8. Tobias Wojtylak marked it work in progress 03/26/26, 15:38

  9. Tobias Wojtylak updated the commit message in patch set 4 V +1 03/26/26, 15:42

  10. core-ci voted on patch set 4 V +1 03/26/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98801

  11. Tobias Wojtylak updated the commit message in patch set 5 V +1 03/27/26, 08:23

  12. Tobias Wojtylak marked it ready for review 03/27/26, 08:23

  13. core-ci voted on patch set 5 V +1 03/27/26, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98840

  14. Tobias Wojtylak uploaded patch set 6 V +1 03/30/26, 09:00

  15. core-ci voted on patch set 6 V +1 03/30/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99018

  16. Tobias Wojtylak marked it ready for review 03/30/26, 09:23

  17. Stefan Bürk commented on patch set 6 CR -1 03/30/26, 19:55

    Unresolved

    Also related to #108049. This change modifies a interface, which is technically stated as internal before LTS but at least the "FEATURE" restfile of the change needs to be adjusted and mentanting the difference between 14.0 and 14.2 - and in my eyes additionally important restfile ! https://review.typo3.org/c/Packages/TYPO3.CMS/+/93366/6/typo3/sysext/backend/Classes/Localization/LocalizationHandlerInterface.php Even internally we should inform (early) adopters of the new API - okay, I know that now for our extensions but would have possible missed that if now changelog correction/information is added. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90489/90/typo3/sysext/core/Documentation/Changelog/14.0/Feature-108049-ModernizedTranslationWorkflow.rst#106
  18. Benni Mack updated the commit message in patch set 7 CR -1 V +1 04/22/26, 07:28

  19. Benni Mack abandoned the change 09/04/26, 06:10

    wont do