Review main Abandoned

93367[BUGFIX] Skip links to untranslated records

Mathias Brodala CR 0 V 0 Easy +0 −0 updated 10/02/26, 09:30

Commit message

This fixes a regression present since 13.0 which evidently was not
caught by existing tests.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 0

No files imported.

Review log 710

  1. Mathias Brodala uploaded patch set 1 03/26/26, 13:05

  2. Stefan Bürk commented on patch set 1 03/26/26, 13:16

    DatabaseRecordLinkBuilder.php:108

    This is needed because the condition in L115 has changed from checking against integer 0 to NULL https://review.typo3.org/c/Packages/TYPO3.CMS/+/93367/1/typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php#115 in #102775
  3. Mathias Brodala commented on patch set 1 03/26/26, 13:34

    DatabaseRecordLinkBuilder.php:108 Reply Unresolved

    Exactly. The main question is why no test caught this back then.
  4. core-ci voted on patch set 1 V +1 03/26/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98779

  5. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:44

  6. core-ci voted on patch set 2 V +1 04/22/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100779

  7. Benni Mack rebased onto patch set 3 V +1 10/02/26, 09:07

  8. core-ci voted on patch set 3 V +1 10/02/26, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109895

  9. Benni Mack abandoned the change 10/02/26, 09:25

  10. Benni Mack commented on patch set 3 10/02/26, 09:30

    great rebase - now we only had the commit message :)