Review main Merged

9337[BUGFIX] Excludefieds must exclude admin only tables

Georg Ringer CR +2 V +2 Easy +5 −2 updated 06/03/13, 20:49

Commit message

The field "allowed excludefields" should not show
fields of tables which are restricted to admins,
either because of the flag adminOnly =1 or
rootLevel = 1

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 7

  1. Steffen Ritter commented on patch set 1 03/09/12, 06:58

    Verified; Looks good to me, but someone else must approve
  2. Steffen Ritter commented on patch set 2 V 0 03/09/12, 06:58

    by team member; Looks good to me, approved
  3. Philipp Gampe commented on patch set 2 03/09/12, 06:58

    Verified; Looks good to me, but someone else must approve Rebased to current master.
  4. Philipp Gampe uploaded patch set 2 03/09/12, 06:58

  5. Mr. Jenkins commented on patch set 1 03/09/12, 06:58

  6. Mr. Jenkins commented on patch set 2 03/09/12, 06:58

  7. Steffen Ritter merged patch set 2 03/09/12, 06:58