Review main Merged

93373[TASK] Migrate more GU::getIndpEnv() to NormalizedParams

Benni Mack CR +2 V +2 Normal +162 −87 updated 03/27/26, 07:08

Commit message

This change reduces the usages down to 4.

Many places which were needed are now migrated via

> NormalizedParams::createFromServerParams($_SERVER)

which serves as a direct replacement to getIndpEnv()
where there is no Request object, with the advantage
of not being cached (which is OK in these places,
where we need to look at the REMOTE_ADDR).

The patch makes clear the NormalizedParams factory methods
are meant to be framework related (as in: not extension
related) functionality, which is why we declare them
@internal for now.

We enrich some places with @todo markers where API could
and should be changed in order to get Request related
data actively hand over.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1014

  1. Benni Mack uploaded patch set 1 03/26/26, 17:45

  2. Benni Mack uploaded patch set 2 03/26/26, 17:51

  3. core-ci voted on patch set 1 V -1 03/26/26, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98808

  4. core-ci voted on patch set 2 V -1 03/26/26, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98810

  5. Christian Kuhn commented on patch set 2 CR -1 03/26/26, 18:31

    on it.
  6. Christian Kuhn uploaded patch set 3 CR -1 V -1 03/26/26, 18:44

  7. Christian Kuhn voted on patch set 3 CR -1 03/26/26, 18:45

  8. core-ci voted on patch set 3 V -1 03/26/26, 18:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98813

  9. Christian Kuhn uploaded patch set 4 CR -1 V -1 03/26/26, 19:53

  10. core-ci voted on patch set 4 V +1 03/26/26, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98818

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 03/26/26, 20:07

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/26/26, 23:56

  13. Benni Mack voted on patch set 4 CR +2 V +2 03/27/26, 07:08

  14. Benni Mack merged patch set 5 03/27/26, 07:08