Review 13.4 Merged

93374[BUGFIX] Set request on form when built via ArrayFormFactory

Garvin Hicking CR +2 V +2 Normal +51 −0 updated 03/27/26, 07:51

Commit message

Assign the current request to the form instance during
creation in ArrayFormFactory.

This ensures the request is consistently available on the
form object, regardless of how the form is created.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Garvin Hicking commented on patch set 1 03/26/26, 19:22

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.php
  2. Garvin Hicking commented on patch set 2 03/26/26, 19:24

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 03/26/26, 19:24

  4. core-ci voted on patch set 1 V -1 03/26/26, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98815

  5. core-ci voted on patch set 2 V -1 03/26/26, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98816

  6. Josua Vogel commented on patch set 2 03/26/26, 21:23

    You need to remove all tests except the new ones, since the others are specific to v14
  7. Garvin Hicking commented on patch set 2 03/27/26, 07:13

    Reply

    Yeah thanks, was just a quick shot to get the file in
  8. Josua Vogel commented on patch set 2 03/27/26, 07:15

    Reply

    Acknowledged
  9. Garvin Hicking uploaded patch set 3 V -1 03/27/26, 07:26

    strip down test
  10. core-ci voted on patch set 3 V +1 03/27/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98835

  11. Garvin Hicking voted on patch set 3 CR +2 V +2 03/27/26, 07:50

  12. Garvin Hicking merged patch set 4 03/27/26, 07:51