93374[BUGFIX] Set request on form when built via ArrayFormFactory
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 2
Review log 912
-
Garvin Hicking commented on patch set 1 03/26/26, 19:22
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.php -
Garvin Hicking commented on patch set 2 03/26/26, 19:24
Published edit on patch set 1. -
Garvin Hicking marked it ready for review 03/26/26, 19:24
-
core-ci voted on patch set 1 V -1 03/26/26, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98815
-
core-ci voted on patch set 2 V -1 03/26/26, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98816
-
Josua Vogel commented on patch set 2 03/26/26, 21:23
You need to remove all tests except the new ones, since the others are specific to v14 -
Garvin Hicking commented on patch set 2 03/27/26, 07:13
Reply
Yeah thanks, was just a quick shot to get the file in -
Josua Vogel commented on patch set 2 03/27/26, 07:15
Reply
Acknowledged -
Garvin Hicking uploaded patch set 3
V -103/27/26, 07:26strip down test -
core-ci voted on patch set 3 V +1 03/27/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98835
-
Garvin Hicking voted on patch set 3 CR +2 V +2 03/27/26, 07:50
-
Garvin Hicking merged patch set 4 03/27/26, 07:51