Review main Merged

93395[TASK] Integrate FormEngine-based rendering for user settings

Bastien Lutz CR +2 V +2 Expert +646 −552 updated 03/31/26, 05:23

Commit message

This replaces manual HTML rendering in
SetupModuleController::renderUserSetup() with FormEngine-based
rendering via a custom BackendUserSettingsElement.

The new approach uses a fake TCA table (be_users_settings) and a
custom FormDataGroup to compile user settings through the standard
FormEngine pipeline (FormDataCompiler -> NodeFactory ->
FormResultCompiler).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 2336

Show 711 earlier messages
  1. Bastien Lutz uploaded patch set 1 03/27/26, 10:01

  2. core-ci voted on patch set 1 V -1 03/27/26, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98849

  3. Bastien Lutz uploaded patch set 2 V -1 03/27/26, 10:39

  4. core-ci voted on patch set 2 V +1 03/27/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98854

  5. Bastien Lutz uploaded patch set 3 V +1 03/27/26, 12:58

  6. Bastien Lutz marked it ready for review 03/27/26, 13:00

  7. core-ci voted on patch set 3 V +1 03/27/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98872

  8. Garvin Hicking commented on patch set 3 03/27/26, 16:11

    I cannot judge all of the code, but it looks solid to me. It mostly works, but the "Dark / Light mode" setting does not take effect when I change it. It always reverts to Dark mode. The theme change however works. And is also directly changed when submitting.

    UserSettingsSchema.php:166

    @internal

    SetupModuleController.php:655

    use `->translate()` domain syntax here

    BackendUserSettingsElement.php:411

    please use the new language domain syntax everywhere inside this file `$lang->translate('core.XXX', 'bla.bla');`

    BackendUserSettingsElement.php:697

    We should skip the most ugly bparams syntax we ever had due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/92693 ?

    UserSettingsDatabaseEditRow.php:53

    I have not checked this: Could extensions previously extend user settings, and was this here done automatically? If so, extensions would proably need a way to hook their data into this result here too? PSR-14 event + ReST file?

    Modules.php:12

    Is this changed needed? If not we could preserve bookmarks and so to not change, and not setup a route alias!?
  9. Bastien Lutz uploaded patch set 4 V +1 03/30/26, 09:01

  10. Bastien Lutz commented on patch set 4 03/30/26, 09:02

    UserSettingsSchema.php:166 Reply

    Done

    SetupModuleController.php:655 Reply

    Done
  11. core-ci voted on patch set 4 V +1 03/30/26, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99019

  1. Bastien Lutz uploaded patch set 5 V +1 03/30/26, 14:41

  2. core-ci voted on patch set 5 V -1 03/30/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99075

  3. Bastien Lutz uploaded patch set 6 V -1 03/30/26, 16:02

  4. core-ci voted on patch set 6 V -1 03/30/26, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99091

  5. Bastien Lutz uploaded patch set 7 V -1 03/30/26, 16:15

  6. Bastien Lutz commented on patch set 7 03/30/26, 16:16

    This change is ready for review.

    Reply

    Done

    BackendUserSettingsElement.php:697 Reply

    Done
  7. Bastien Lutz uploaded patch set 8 03/30/26, 16:22

  8. core-ci voted on patch set 7 V -1 03/30/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99093

  9. core-ci voted on patch set 8 V +1 03/30/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99094

  10. Benni Mack uploaded patch set 9 V +1 03/30/26, 16:55

  11. Benni Mack commented on patch set 9 03/30/26, 16:57

    BackendUserSettingsElement.php:411 Reply

    Done

    UserSettingsDatabaseEditRow.php:53 Reply

    Done

    Modules.php:12 Reply

    Done
  12. Benni Mack uploaded patch set 10 03/30/26, 17:01

  13. core-ci voted on patch set 9 V -1 03/30/26, 17:06 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 10 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99096

  14. core-ci voted on patch set 10 V -1 03/30/26, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99097

  15. Benni Mack uploaded patch set 11 V -1 03/30/26, 17:14

  16. Benni Mack uploaded patch set 12 03/30/26, 17:17

  17. core-ci voted on patch set 11 V +1 03/30/26, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99100

  18. core-ci voted on patch set 12 V +1 03/30/26, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99101

  19. Garvin Hicking commented on patch set 12 03/30/26, 18:08

    "Personal settings" works, but all other tabs (backend appearance, personalization) do not display the changed value after submit. The UI dark/light mode takes effect, but the dropdown then does not show the right value then. Also all other fields reset to their first dropdown field / default value. Also after resetting my user preferences.

    UserSettingsItemsProcFunc.php:119

    (I just see this now but we could move dateFormatter outside the for loop - Resolving this for a later time or if another patchset gets pushed?)
  20. Benni Mack uploaded patch set 13 V +1 03/30/26, 20:08

  21. Benni Mack commented on patch set 13 03/30/26, 20:08

    Reply

    Done
  22. core-ci voted on patch set 13 V +1 03/30/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99117

  23. Benni Mack voted on patch set 13 CR +1 V +1 03/30/26, 20:45

  24. Garvin Hicking voted on patch set 13 CR +2 V +2 03/31/26, 05:23

  25. Garvin Hicking merged patch set 14 03/31/26, 05:23