93395[TASK] Integrate FormEngine-based rendering for user settings
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Backend/ColorScheme.php+3 −3
- typo3/sysext/backend/Classes/Form/NodeFactory.php+3 −0
- typo3/sysext/core/Classes/Authentication/UserSettingsSchema.php2+15 −5
- typo3/sysext/setup/Classes/Configuration/UserSettingsTcaConfiguration.phpnew+60 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+109 −504
- typo3/sysext/setup/Classes/Form/Element/AvatarElement.phpnew+85 −0
- typo3/sysext/setup/Classes/Form/FormDataGroup/UserSettingsDataGroup.phpnew+47 −0
- typo3/sysext/setup/Classes/Form/FormDataProvider/UserSettingsDatabaseEditRow.php2new+70 −0
- typo3/sysext/setup/Classes/UserFunctions/UserSettingsItemsProcFunc.php1new+134 −0
- typo3/sysext/setup/Configuration/TCA/Overrides/be_users.php+30 −7
- typo3/sysext/setup/Resources/Private/Templates/Main.fluid.html+4 −33
- typo3/sysext/setup/ext_localconf.phpnew+86 −0
Review log 2336
Show 711 earlier messages
-
Bastien Lutz uploaded patch set 1 03/27/26, 10:01
-
core-ci voted on patch set 1 V -1 03/27/26, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98849
-
Bastien Lutz uploaded patch set 2
V -103/27/26, 10:39 -
core-ci voted on patch set 2 V +1 03/27/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98854
-
Bastien Lutz uploaded patch set 3
V +103/27/26, 12:58 -
Bastien Lutz marked it ready for review 03/27/26, 13:00
-
core-ci voted on patch set 3 V +1 03/27/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98872
-
Garvin Hicking commented on patch set 3 03/27/26, 16:11
I cannot judge all of the code, but it looks solid to me. It mostly works, but the "Dark / Light mode" setting does not take effect when I change it. It always reverts to Dark mode. The theme change however works. And is also directly changed when submitting.UserSettingsSchema.php:166@internalSetupModuleController.php:655use `->translate()` domain syntax hereBackendUserSettingsElement.php:411please use the new language domain syntax everywhere inside this file `$lang->translate('core.XXX', 'bla.bla');`BackendUserSettingsElement.php:697We should skip the most ugly bparams syntax we ever had due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/92693 ?UserSettingsDatabaseEditRow.php:53I have not checked this: Could extensions previously extend user settings, and was this here done automatically? If so, extensions would proably need a way to hook their data into this result here too? PSR-14 event + ReST file?Modules.php:12Is this changed needed? If not we could preserve bookmarks and so to not change, and not setup a route alias!? -
Bastien Lutz uploaded patch set 4
V +103/30/26, 09:01 -
Bastien Lutz commented on patch set 4 03/30/26, 09:02
UserSettingsSchema.php:166ReplyDoneSetupModuleController.php:655ReplyDone -
core-ci voted on patch set 4 V +1 03/30/26, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99019
-
Bastien Lutz uploaded patch set 5
V +103/30/26, 14:41 -
core-ci voted on patch set 5 V -1 03/30/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99075
-
Bastien Lutz uploaded patch set 6
V -103/30/26, 16:02 -
core-ci voted on patch set 6 V -1 03/30/26, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99091
-
Bastien Lutz uploaded patch set 7
V -103/30/26, 16:15 -
Bastien Lutz commented on patch set 7 03/30/26, 16:16
This change is ready for review.Reply
DoneBackendUserSettingsElement.php:697ReplyDone -
Bastien Lutz uploaded patch set 8 03/30/26, 16:22
-
core-ci voted on patch set 7 V -1 03/30/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99093
-
core-ci voted on patch set 8 V +1 03/30/26, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99094
-
Benni Mack uploaded patch set 9
V +103/30/26, 16:55 -
Benni Mack commented on patch set 9 03/30/26, 16:57
BackendUserSettingsElement.php:411ReplyDoneUserSettingsDatabaseEditRow.php:53ReplyDoneModules.php:12ReplyDone -
Benni Mack uploaded patch set 10 03/30/26, 17:01
-
core-ci voted on patch set 9 V -1 03/30/26, 17:06 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 10 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99096
-
core-ci voted on patch set 10 V -1 03/30/26, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99097
-
Benni Mack uploaded patch set 11
V -103/30/26, 17:14 -
Benni Mack uploaded patch set 12 03/30/26, 17:17
-
core-ci voted on patch set 11 V +1 03/30/26, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99100
-
core-ci voted on patch set 12 V +1 03/30/26, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99101
-
Garvin Hicking commented on patch set 12 03/30/26, 18:08
"Personal settings" works, but all other tabs (backend appearance, personalization) do not display the changed value after submit. The UI dark/light mode takes effect, but the dropdown then does not show the right value then. Also all other fields reset to their first dropdown field / default value. Also after resetting my user preferences.UserSettingsItemsProcFunc.php:119(I just see this now but we could move dateFormatter outside the for loop - Resolving this for a later time or if another patchset gets pushed?) -
Benni Mack uploaded patch set 13
V +103/30/26, 20:08 -
Benni Mack commented on patch set 13 03/30/26, 20:08
Reply
Done -
core-ci voted on patch set 13 V +1 03/30/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99117
-
Benni Mack voted on patch set 13 CR +1 V +1 03/30/26, 20:45
-
Garvin Hicking voted on patch set 13 CR +2 V +2 03/31/26, 05:23
-
Garvin Hicking merged patch set 14 03/31/26, 05:23