Review main Merged

93399[BUGFIX] Use database column as source of truth for form identifier

Josua Vogel CR +2 V +2 Easy +2 −0 updated 03/27/26, 15:56

Commit message

DatabaseStorageAdapter::read() extracted the form identifier from the
JSON configuration payload, while findAll() used the database column.
This could lead to inconsistent behavior if the two values diverged.

Override the identifier from the JSON payload with the value from the
database column to ensure a single source of truth.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Josua Vogel uploaded patch set 1 03/27/26, 13:06

  2. core-ci voted on patch set 1 V +1 03/27/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98875

  3. Sven Liebert voted on patch set 1 CR +1 V +1 03/27/26, 15:30

  4. Benni Mack voted on patch set 1 CR +2 V +2 03/27/26, 15:56

  5. Benni Mack merged patch set 2 03/27/26, 15:56