Review main Merged

93404[BUGFIX] Cast numeric property key to string in forProperty()

Torben Hansen CR +2 V +2 Easy +25 −1 updated 03/27/26, 16:21

Commit message

When a form contains nested objects accessed via numeric
iteration index, the resulting `__trustedProperties` hash
contains numerically-keyed nested arrays.

During property mapping configuration,
`modifyPropertyMappingConfiguration()` passes these integer
keys directly to `forProperty()`, which expects a
string argument, causing a TypeError.

The fix explicitly casts `$innerKey` to string before
passing it to `forProperty()`. Additionally, a unit test
for the scenario has been added.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Torben Hansen uploaded patch set 1 03/27/26, 14:35

  2. core-ci voted on patch set 1 V +1 03/27/26, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98888

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 03/27/26, 15:53

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 03/27/26, 15:55

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 03/27/26, 16:21

  6. Garvin Hicking merged patch set 2 03/27/26, 16:21