93405[BUGFIX] Prevent TypeError on NULL in RecordFieldPreviewProcessor
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 2
Files 1
Review log 912
-
Garvin Hicking uploaded patch set 1 03/27/26, 15:41
-
Garvin Hicking commented on patch set 2 03/27/26, 15:43
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 03/27/26, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98894
-
core-ci voted on patch set 1 V +1 03/27/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98893
-
Oliver Klee commented on patch set 2 03/27/26, 16:28
RecordFieldPreviewProcessor.php:127`RawRecord::get()` returns `mixed` (and I'd assume the records are `RawRecords`). So, to ensure that we only use strings, we should use this: ```suggestion if (!is_string($content)) { ``` -
Garvin Hicking commented on patch set 3
V +103/27/26, 17:03Published edit on patch set 2. -
Garvin Hicking commented on patch set 3 03/27/26, 17:03
RecordFieldPreviewProcessor.php:127ReplyIndeed, good suggestion, thanks! -
core-ci voted on patch set 3 V +1 03/27/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98904
-
Oliver Klee voted on patch set 3 CR +1 03/28/26, 09:56
-
Georg Ringer voted on patch set 3 CR +1 V +1 03/31/26, 12:17
-
Benni Mack voted on patch set 3 CR +2 V +2 03/31/26, 12:32
-
Benni Mack merged patch set 4 03/31/26, 12:32