Review main Merged

93406[TASK] Minor code cleanups in EXT:form

Josua Vogel CR +2 V +2 Normal +38 −36 updated 03/30/26, 11:01

Commit message

Avoid redundant function calls in validators by extracting results
into local variables. Simplify isset+is_array combinations to
is_array($x ?? null) and replace ?? false with ?? null in is_array()
checks across the extension. Remove unnecessary global-namespace
backslashes on built-in functions. Replace GeneralUtility::makeInstance()
with new for the final FinisherVariableProvider class. Small improvements
to AbstractFinisher internals.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 89

  1. Josua Vogel uploaded patch set 1 03/27/26, 16:12

  2. core-ci voted on patch set 1 V +1 03/27/26, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98898

  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/28/26, 10:26

  4. Garvin Hicking commented on patch set 1 03/28/26, 18:03

    FinisherContext.php:63

    This feels BC to me because it will prevent Xclassing or DI replacement?
  5. Josua Vogel commented on patch set 1 03/29/26, 12:05

    FinisherContext.php:63 Reply

    is internal :)
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 03/29/26, 12:18

    FinisherContext.php:63 Reply

    Sorry, missed that.
  7. Ravi Sachaniya voted on patch set 1 CR +1 V +1 03/30/26, 06:28

  8. Garvin Hicking voted on patch set 1 CR +2 V +2 03/30/26, 11:01

  9. Garvin Hicking merged patch set 2 03/30/26, 11:01