Review main Merged

93409[TASK] Clarify usage recommendation for `GeneralUtility::makeInstance`

Elias Häußler CR +2 V +2 Easy +13 −5 updated 03/28/26, 12:23

Commit message

Updates the docblock of `GeneralUtility::makeInstance`, reflecting the
latest adaptions and recommendations related to the usage of this
method.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Elias Häußler uploaded patch set 1 03/27/26, 17:15

  2. core-ci voted on patch set 1 V +1 03/27/26, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98905

  3. Nikita Hovratov voted on patch set 1 CR +1 V +1 03/27/26, 17:28

  4. Torben Hansen voted on patch set 1 CR +1 V +1 03/27/26, 17:29

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 03/27/26, 17:51

  6. Garvin Hicking commented on patch set 1 03/27/26, 17:51

    I think we should even backport this to v13.
  7. Elias Häußler rebased onto patch set 2 CR +1 V +1 03/28/26, 10:47

  8. Elias Häußler commented on patch set 2 03/28/26, 10:47

    Reply

    Makes sense, thanks for the suggestion. Please vote again 😊
  9. Elias Häußler commented on patch set 2 03/28/26, 10:47

    Reply

    Done
  10. Georg Ringer voted on patch set 2 CR +1 V +1 03/28/26, 10:53

  11. core-ci voted on patch set 2 V +1 03/28/26, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98945

  12. Torben Hansen voted on patch set 2 CR +1 V +1 03/28/26, 10:57

  13. Oliver Klee voted on patch set 2 CR +1 V +1 03/28/26, 11:39

  14. Garvin Hicking voted on patch set 2 CR +2 V +2 03/28/26, 12:22

  15. Garvin Hicking merged patch set 3 03/28/26, 12:23